Removed null constraints on NodeInfo fields that are returned null from Amazon OpenSearch Service #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TransportAddress Signed-off-by: Dan Cecoi <[email protected]>
dancristiancecoi
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
|
Have some questions about the Changelog. I want this backported to 2.x if approved, do I add an entry to the 2.x section as well or just to the 3.x one? |
2.x I believe |
Entries should only go under one section or the other not both, so for your case It would go under only the |
Xtansia
requested changes
Aug 7, 2024
| @@ -60,11 +60,13 @@ public class NodeInfo implements PlainJsonSerializable { | |||
|
|
|||
| private final String buildType; | |||
|
|
|||
| @Nullable | |||
There was a problem hiding this comment.
The relevant getters below should also get @Nullable annotations
| @@ -828,7 +834,7 @@ public final Builder transport(Function<NodeInfoTransport.Builder, ObjectBuilder | |||
| * <p> | |||
| * API name: {@code transport_address} | |||
| */ | |||
| public final Builder transportAddress(String value) { | |||
| public final Builder transportAddress(@Nullable String value) { | |||
There was a problem hiding this comment.
Please fix the double space here, or just run ./gradlew spotlessApply
Suggested change
| public final Builder transportAddress(@Nullable String value) { | |
| public final Builder transportAddress(@Nullable String value) { |
…white space Signed-off-by: Dan Cecoi <[email protected]>
|
Thanks guys! |
…t#1109) * Use own copy of PercentCodec for URI path encoding Adapted from Apache HttpComponents HttpCore v5's https://github.com/apache/httpcomponents-core/blob/e009a923eefe79cf3593efbb0c18a3525ae63669/httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java Signed-off-by: Thomas Farr <[email protected]> * Refactor PercentCodec a bit Signed-off-by: Thomas Farr <[email protected]> * Add change log Signed-off-by: Thomas Farr <[email protected]> * Switch to system property Signed-off-by: Thomas Farr <[email protected]> * spotless Signed-off-by: Thomas Farr <[email protected]> * Add UPGRADING note Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]>
…ensearch-project#1117) * Add failing test Signed-off-by: Thomas Farr <[email protected]> * Fixed deserialization of SearchRequest when `_source` is an array Signed-off-by: Thomas Farr <[email protected]> * Fix docker compose error Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]>
* Rename genericArgs to typeParams Signed-off-by: Thomas Farr <[email protected]> * Fix required path param handling Signed-off-by: Thomas Farr <[email protected]> * Correctly generate AcknowledgedResponseBase Signed-off-by: Thomas Farr <[email protected]> * Generate DeleteDanglingIndexRequest Signed-off-by: Thomas Farr <[email protected]> * Correctly generate DeleteDanglingIndexResponse Signed-off-by: Thomas Farr <[email protected]> * Generate import_dangling_index Signed-off-by: Thomas Farr <[email protected]> * Generate ListDanglingIndicesRequest Signed-off-by: Thomas Farr <[email protected]> * Generate ErrorCause Signed-off-by: Thomas Farr <[email protected]> * Generate NodeStatistics Signed-off-by: Thomas Farr <[email protected]> * Generate DanglingIndex Signed-off-by: Thomas Farr <[email protected]> * Generate ListDanglingIndicesResponse Signed-off-by: Thomas Farr <[email protected]> * Generate DanglingIndicesClient Signed-off-by: Thomas Farr <[email protected]> * Fixes Signed-off-by: Thomas Farr <[email protected]> * Changelog and Upgrading Signed-off-by: Thomas Farr <[email protected]> * Fix javadoc Signed-off-by: Thomas Farr <[email protected]> * Fix tests Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Thomas Farr <[email protected]>
…ect#1125) * Bump org.eclipse.parsson:parsson from 1.1.6 to 1.1.7 Bumps [org.eclipse.parsson:parsson](https://github.com/eclipse-ee4j/parsson) from 1.1.6 to 1.1.7. - [Release notes](https://github.com/eclipse-ee4j/parsson/releases) - [Commits](eclipse-ee4j/parsson@1.1.6...1.1.7) --- updated-dependencies: - dependency-name: org.eclipse.parsson:parsson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
|
Ugh, I messed up the rebase trying to solve the conflicts. I will close this PR and open a new one as it will be quicker this way. Sorry :D Raised here: #1132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes null constraints on NodeInfo.Host, NodeInfo.Ip, NodeInfo.TransportAddress that are returned null from Amazon OpenSearch Service when performing a NodeInfoRequest
Issues Resolved
#1129
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.