-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helm folder and add a submodule for Helm Charts #72
Conversation
Signed-off-by: TheAlgo <[email protected]>
Signed-off-by: TheAlgo <[email protected]>
Signed-off-by: TheAlgo <[email protected]>
@peterzhuamazon @DandyDeveloper @smlx Have a look a this cleaning when free. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues, but why out of interest?
Perhaps update the README as well since we have the chance?
Yes @TheAlgo probably we can just add a simple README within the helm-charts folder and explain why we deprecated this part and more to helm-charts repo? Thanks. |
@peterzhuamazon @DandyDeveloper I agree but wanted to understand why we want to keep the helm folder lying here and create confusions. People may land to this repo and install the stale chart and create issues onto that. IMO deprecation is not a good word to describe the initial chart since it was WIP. We just moved our code. But yeah if everyone else agrees on not removing the folder I can change the behaviour. |
[IMO]: Also if we have a submodule in future this can also serve as an index , since everyone can make a PR to create a new tool or facility for deploying OpenSearch stack starting from here. |
Description
Remove stale folders of Helm Charts from the repo and add pointers to the new helm repo
Issues Resolved
#66
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.