Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Helm folder and add a submodule for Helm Charts #72

Merged
merged 3 commits into from
Sep 23, 2021

Conversation

TheAlgo
Copy link
Member

@TheAlgo TheAlgo commented Sep 21, 2021

Description

Remove stale folders of Helm Charts from the repo and add pointers to the new helm repo

Issues Resolved

#66

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TheAlgo
Copy link
Member Author

TheAlgo commented Sep 21, 2021

@peterzhuamazon @DandyDeveloper @smlx Have a look a this cleaning when free. Thanks

Copy link
Collaborator

@DandyDeveloper DandyDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, but why out of interest?

Perhaps update the README as well since we have the chance?

@peterzhuamazon
Copy link
Member

No issues, but why out of interest?

Perhaps update the README as well since we have the chance?

Yes @TheAlgo probably we can just add a simple README within the helm-charts folder and explain why we deprecated this part and more to helm-charts repo?

Thanks.

@TheAlgo
Copy link
Member Author

TheAlgo commented Sep 22, 2021

@peterzhuamazon @DandyDeveloper I agree but wanted to understand why we want to keep the helm folder lying here and create confusions. People may land to this repo and install the stale chart and create issues onto that. IMO deprecation is not a good word to describe the initial chart since it was WIP. We just moved our code.

But yeah if everyone else agrees on not removing the folder I can change the behaviour.

@TheAlgo
Copy link
Member Author

TheAlgo commented Sep 22, 2021

[IMO]: Also if we have a submodule in future this can also serve as an index , since everyone can make a PR to create a new tool or facility for deploying OpenSearch stack starting from here.

@peterzhuamazon peterzhuamazon merged commit 6d96874 into opensearch-project:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Migration][Helm] Cleanup the helm folders in devops repo and add pointers to helm-charts repo
3 participants