-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to cypress 12 (into feature/cypress12) #668
Upgrade to cypress 12 (into feature/cypress12) #668
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Possible replacement of this one PR: |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Hi, The snapshot workflow has 1 error on cypress9 but 12 errors on cypress12, awaiting cc: @ananzh PS: added @RyanL1997 to take a look together. Thanks. |
Cypress functional test fixed PR: #682 |
Is this still slated for 2.8? |
There are a lot more tests so we will postpone this. |
Rebasing to |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Could a maintainer of this repo please review this / merge this into the feature ( I plan to open up issues in all of the dashboards plugin repos to ensure their tests run with Cypress12 and request that any dashboards plugin that needs to update tests make a PR against the Once all dashboards plugins have verified their tests run with Cypress12 we can proceed to merging the feature branch into main. The migration guide for cypress can be found here: https://docs.cypress.io/guides/references/migration-guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need more changes from individual plugin repos.
And @cwperks @RyanL1997 will help with that meta issue.
Thanks
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-668-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 63aeb324b5378984cce6d7846d6c719d6c81428f
# Push it to GitHub
git push --set-upstream origin backport/backport-668-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Description
Creating Draft PR to understand what is required to migrate to Cypress 12 from Cypress 9.
For this PR to get the specs working I had to:
cypress/support/index.js
->cypress/support/e2e.js
"cypress/unsafe-to-chain-command": "off"
as there were 290 violations - I will file a follow-up issue to resolve the violations and re-enable the rule.specPattern
to thee2e
section of the cypress confige2e
section of the cypress config was added by another user with a similar PR, I copied that into here and the only modification I made was adding thespecPattern
into that section.Cypress Migration Guide: https://docs.cypress.io/guides/references/migration-guide
Issues Resolved
#408
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.