[NodeJS Upgrade] Make [email protected] install from pre-compiled archive #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov Report
@@ Coverage Diff @@
## main #3558 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 181 181
Lines 5369 5369
=======================================
Hits 4912 4912
Misses 457 457 |
prudhvigodithi
approved these changes
May 24, 2023
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
42 tasks
peterzhuamazon
changed the title
peterzhuamazon
added a commit
that referenced
this pull request
May 25, 2023
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NodeJS Upgrade] Make [email protected] install from pre-compiled archive
https://build.ci.opensearch.org/job/docker-build/3428/console
With node now using 18 instead of 16, [email protected] is not able to compile anymore.
Using the same method as 5.6.0 where a pre-compiled cache package will be downloaded during the image build.
Both 5.6.0 and 9.5.4 are legacy now.
Thanks.
Issues Resolved
#3434
#1563
opensearch-project/opensearch-dashboards-functional-test#408
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.