-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis Builder] Updates tests to visBuilder key #361
Conversation
Signed-off-by: Ashwin Pc <[email protected]>
The OSD build seems to be failing due to other issues. Can we merge this in given the screenshots attached and I can fix any followup issues in a followup PR |
Currently it has label for 2.x backport. Does it need 2.4 backport as well since we already have 2.4 branch? |
Sure |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-361-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89b9c35a7ee333d0df3dbce7347eb705a6a4fffe
# Push it to GitHub
git push --set-upstream origin backport/backport-361-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Yes it does! thank you! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-361-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89b9c35a7ee333d0df3dbce7347eb705a6a4fffe
# Push it to GitHub
git push --set-upstream origin backport/backport-361-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4 Then, create a pull request where the |
I will manually take it to 2.x and try to backport to 2.4 from there. |
Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 89b9c35)
Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 89b9c35) Co-authored-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 89b9c35) Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 8c81484)
Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> (cherry picked from commit 89b9c35) Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit 8c81484) Co-authored-by: Miki <[email protected]>
Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Ashwin Pc <[email protected]> Signed-off-by: Jakub Przybylski <[email protected]>
Signed-off-by: Ashwin Pc [email protected]
Description
The existing VisBuilder tests use the
wizard
key that has now been updated tovisBuilder
. This Pr updates the keys and the tests associated.Screen recordings
basic.spec.js.mp4
dashboard.spec.js.mp4
experimental.spec.js.mp4
Vis Types
area.spec.js.mp4
bar.spec.js.mp4
line.spec.js.mp4
metric.spec.js.mp4
Issues Resolved
related to opensearch-project/OpenSearch-Dashboards#1706
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.