Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Builder] Updates tests to visBuilder key #361

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Nov 2, 2022

Signed-off-by: Ashwin Pc [email protected]

Description

The existing VisBuilder tests use the wizard key that has now been updated to visBuilder. This Pr updates the keys and the tests associated.

Screen recordings
basic.spec.js.mp4
dashboard.spec.js.mp4
experimental.spec.js.mp4

Vis Types

area.spec.js.mp4
bar.spec.js.mp4
line.spec.js.mp4
metric.spec.js.mp4

Issues Resolved

related to opensearch-project/OpenSearch-Dashboards#1706

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashwin-pc ashwin-pc requested a review from a team as a code owner November 2, 2022 09:20
@AMoo-Miki AMoo-Miki added the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 3, 2022
@ashwin-pc
Copy link
Member Author

The OSD build seems to be failing due to other issues. Can we merge this in given the screenshots attached and I can fix any followup issues in a followup PR

@tianleh
Copy link
Member

tianleh commented Nov 3, 2022

Currently it has label for 2.x backport. Does it need 2.4 backport as well since we already have 2.4 branch?

@tianleh
Copy link
Member

tianleh commented Nov 3, 2022

The OSD build seems to be failing due to other issues. Can we merge this in given the screenshots attached and I can fix any followup issues in a followup PR

Sure

@tianleh tianleh merged commit 89b9c35 into opensearch-project:main Nov 3, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-361-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89b9c35a7ee333d0df3dbce7347eb705a6a4fffe
# Push it to GitHub
git push --set-upstream origin backport/backport-361-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-361-to-2.x.

@ashwin-pc
Copy link
Member Author

Currently it has label for 2.x backport. Does it need 2.4 backport as well since we already have 2.4 branch?

Yes it does! thank you!

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-361-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89b9c35a7ee333d0df3dbce7347eb705a6a4fffe
# Push it to GitHub
git push --set-upstream origin backport/backport-361-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-361-to-2.4.

@AMoo-Miki
Copy link
Contributor

I will manually take it to 2.x and try to backport to 2.4 from there.

AMoo-Miki pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit 89b9c35)
kristenTian pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit 89b9c35)

Co-authored-by: Ashwin P Chandran <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit 89b9c35)

Co-authored-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 8c81484)
tianleh pushed a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
(cherry picked from commit 89b9c35)

Co-authored-by: Ashwin P Chandran <[email protected]>
(cherry picked from commit 8c81484)

Co-authored-by: Miki <[email protected]>
@ashwin-pc ashwin-pc deleted the visBuilder branch November 4, 2022 18:35
jakubp-eliatra pushed a commit to sebastianmichalski/opensearch-dashboards-functional-test that referenced this pull request Mar 24, 2023
Signed-off-by: Ashwin Pc <[email protected]>

Signed-off-by: Ashwin Pc <[email protected]>
Signed-off-by: Jakub Przybylski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.4 v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants