-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] toggle for legacy mode #1148
Merged
ananzh
merged 4 commits into
opensearch-project:main
from
kavilla:kavilla/discover/toggle
Mar 18, 2024
Merged
[Discover] toggle for legacy mode #1148
ananzh
merged 4 commits into
opensearch-project:main
from
kavilla:kavilla/discover/toggle
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
March 16, 2024 07:59
ananzh
approved these changes
Mar 17, 2024
@kavilla lint checker failed. could you fix this? |
ashwin-pc
approved these changes
Mar 17, 2024
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
ananzh
approved these changes
Mar 18, 2024
Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* [Discover] toggle for legacy mode * remove async * invert boolean --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 861f8b2)
ananzh
pushed a commit
that referenced
this pull request
Mar 18, 2024
* [Discover] toggle for legacy mode * remove async * invert boolean --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit 861f8b2) Co-authored-by: Kawika Avilla <[email protected]>
kavilla
pushed a commit
to kavilla/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 18, 2024
This reverts commit 861f8b2.
kavilla
pushed a commit
to kavilla/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 18, 2024
This reverts commit 861f8b2. Signed-off-by: Kawika Avilla <[email protected]>
kavilla
added a commit
that referenced
this pull request
Mar 18, 2024
This reverts commit 861f8b2. Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
This reverts commit 861f8b2. Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit e36352b)
kavilla
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit 861f8b2. Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> (cherry picked from commit e36352b) Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address changes from: opensearch-project/OpenSearch-Dashboards#6170
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.