Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] options button in canvas to toggle legacy mode #6170

Merged
merged 12 commits into from
Mar 19, 2024
Merged

[Discover] options button in canvas to toggle legacy mode #6170

merged 12 commits into from
Mar 19, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 16, 2024 •
edited
Loading

Description

Removes top nav bar link and provides a button option.

Issues Resolved

n/a

Screenshot

Screenshot 2024-03-16 at 12 23 07 AM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Mar 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (bfab07c) to head (ee4381b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6170      +/-   ##
==========================================
+ Coverage   67.22%   67.24%   +0.02%     
==========================================
  Files        3344     3344              
  Lines       64796    64796              
  Branches    10427    10427              
==========================================
+ Hits        43556    43572      +16     
+ Misses      18697    18683      -14     
+ Partials     2543     2541       -2
Flag Coverage Δ
Linux_1 31.64% <ø> (ø)
Linux_2 55.45% <ø> (ø)
Linux_3 44.69% <ø> (ø)
Linux_4 35.06% <ø> (ø)
Windows_1 31.67% <ø> (?)
Windows_2 55.41% <ø> (ø)
Windows_3 44.70% <ø> (?)
Windows_4 35.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla kavilla added backport 2.x discover for discover reinvent v2.13.0 labels Mar 16, 2024
ashwin-pc
ashwin-pc previously approved these changes Mar 16, 2024
View reviewed changes
@kavilla kavilla mentioned this pull request Mar 16, 2024
Merged
1 task
@kavilla kavilla force-pushed the kavilla/legacy_toggle branch from 51f0c73 to 1929924 Compare March 16, 2024 15:30
@kavilla
Copy link
Member Author

kavilla commented Mar 18, 2024

@kgcreative what do you think about this?

@kgcreative
Copy link
Member

@kavilla If we're able to align the button top-right instead of top-left, i think that's more consistent with other places where we do additional actions, but that's a minor nice-to-have

@kavilla
Copy link
Member Author

kavilla commented Mar 18, 2024 •
edited
Loading

@kavilla If we're able to align the button top-right instead of top-left, i think that's more consistent with other places where we do additional actions, but that's a minor nice-to-have

like this @kgcreative?:
Screenshot 2024-03-18 at 12 58 03 PM

kavilla pushed a commit to kavilla/opensearch-dashboards-functional-test that referenced this pull request Mar 19, 2024
[Discover] update tests related to legacy view
fddcfdd 
Update tests related to switching from legacy view within the Discover
page.

Requires:
opensearch-project/OpenSearch-Dashboards#6170

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this pull request Mar 19, 2024
Merged
1 task
@opensearch-project opensearch-project deleted a comment from github-actions bot Mar 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

[MANUAL CYPRESS TEST RUN RESULTS]

✅ Cypress test run succeeded!

Inputs:

Test repo: 'kavilla/opensearch-dashboards-functional-test'
Test branch: 'kavilla/discover/toggle'

Test spec:
''

Link to results:

https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8335506987

kavilla added 12 commits March 19, 2024 00:56
@kavilla
[Discover] options button in canvas to toggle legacy mode
38181f1 
Removes top nav bar link and provides a button option.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update changelog
5bd6056 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Update tests
9432bb9 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Use only 1 layer for options and fix storage
213e6ee 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
capitalization
f12c40a 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update snapshot
45d05a6 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update snapshot without plugins
68633c7 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix test for time range to show options
dfad75f 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update test
6fd48aa 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
fix test for filter
500a83f 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
update scripted fields
5915f05 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
move to top right
ee4381b 
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the kavilla/legacy_toggle branch from c10d195 to ee4381b Compare March 19, 2024 00:57
@kavilla kavilla merged commit db9806d into opensearch-project:main Mar 19, 2024
64 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
@github-actions
[Discover] options button in canvas to toggle legacy mode (#6170)
f15c4a4 
* [Discover] options button in canvas to toggle legacy mode

Removes top nav bar link and provides a button option.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit db9806d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 19, 2024
Merged
kavilla added a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Mar 19, 2024
@kavilla
[Discover] update tests related to legacy view (#1155)
6a551e8 
Update tests related to switching from legacy view within the Discover
page.

Requires:
opensearch-project/OpenSearch-Dashboards#6170

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Mar 19, 2024
@kavilla @github-actions
[Discover] update tests related to legacy view (#1155)
ca4df36 
Update tests related to switching from legacy view within the Discover
page.

Requires:
opensearch-project/OpenSearch-Dashboards#6170

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
(cherry picked from commit 6a551e8)
ashwin-pc pushed a commit that referenced this pull request Mar 19, 2024
@opensearch-trigger-bot @github-actions
[Discover] options button in canvas to toggle legacy mode (#6170) (#6191
00566ef 
)

* [Discover] options button in canvas to toggle legacy mode

Removes top nav bar link and provides a button option.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit db9806d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit to opensearch-project/opensearch-dashboards-functional-test that referenced this pull request Mar 19, 2024
@opensearch-trigger-bot @kavilla
[Discover] update tests related to legacy view (#1155) (#1157)
c1357d9 
Update tests related to switching from legacy view within the Discover
page.

Requires:
opensearch-project/OpenSearch-Dashboards#6170

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
(cherry picked from commit 6a551e8)

Co-authored-by: Kawika Avilla <[email protected]>
@Tostti Tostti mentioned this pull request Apr 4, 2024
Closed
4 tasks
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 7, 2024
@kavilla @SuZhou-Joe
[Discover] options button in canvas to toggle legacy mode (opensearch…
62834fe 
…-project#6170)

* [Discover] options button in canvas to toggle legacy mode

Removes top nav bar link and provides a button option.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
SuZhou-Joe pushed a commit to ruanyl/OpenSearch-Dashboards that referenced this pull request Apr 7, 2024
@kavilla @SuZhou-Joe
[Discover] options button in canvas to toggle legacy mode (opensearch…
1f2cb35 
…-project#6170)

* [Discover] options button in canvas to toggle legacy mode

Removes top nav bar link and provides a button option.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent distinguished-contributor v2.13.0
Projects
Test roadmap format
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kavilla @kgcreative @ruanyl @ashwin-pc @abbyhu2000