Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integ-test notification #5081

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Oct 9, 2024

Description

  • Adds new jenkinsfile to asynchronously create, update and close integration test failure issues.
  • Removes the test notification mechanism via integ-test workflows

Issues Resolved

closes #5038

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>


pipeline {
agent { label 'Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not use this as this is specifically for gradle check and only runs once and delete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any recommendation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use ubuntu then use the docker builder one
If not, then use a generic x64 docker host.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host
Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are going to run directly on agent node without docker container?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @prudhvigodithi to take a look to update that jenkinsfile to use other runners.
I still think using a docker container here is more clean.
As using the agent might have cleanup issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host in jenkinsfile https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check-flaky-test-issue-creation.jenkinsfile because:

  • This gradle-check-flaky-test-issue-creation.jenkinsfile comes under the same family gradle-check hence used the same.
  • Mainly using Jenkins-Agent-Ubuntu2004-X64-M58xlarge-Single-Host because of the latest curl version which supports --aws-sigv4 flag.

But looks to me like this Jenkins-Agent-AL2023-X64-C54xlarge-Docker-Host (coming from https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/distribution-build.jenkinsfile#L876-L881) also has that latest curl version that supports --aws-sigv4 flag.

Comment on lines +24 to +26
H */6 * * * %INPUT_MANIFEST=2.17.2/opensearch-2.17.2.yml
H */6 * * * %INPUT_MANIFEST=2.18.0/opensearch-2.18.0.yml
H */6 * * * %INPUT_MANIFEST=3.0.0/opensearch-3.0.0.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update the input manifest generation workflow to update this section alongside check-for-build as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Will take that up in next iteration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create an issue for that since you seems to close #5038 in this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done #5083
Thanks!

Signed-off-by: Sayali Gaikawad <[email protected]>
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR for now as I am ok with the function.
Tho I do think we can improve it later with docker container instead of directly running on the agent.

Thanks.

@gaiksaya gaiksaya merged commit a73f6c0 into opensearch-project:main Oct 9, 2024
10 checks passed
@gaiksaya gaiksaya deleted the testNotificationrefactor branch October 9, 2024 05:34
@gaiksaya
Copy link
Member Author

gaiksaya commented Oct 9, 2024

Created the workflow in jenkins : https://build.ci.opensearch.org/job/integ-test-notification/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Revamp build and test failure notification system
3 participants