Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp build and test failure notification system #5038

Closed
gaiksaya opened this issue Sep 18, 2024 · 0 comments · Fixed by #5081
Closed

Revamp build and test failure notification system #5038

gaiksaya opened this issue Sep 18, 2024 · 0 comments · Fixed by #5081
Assignees
Labels
enhancement New Enhancement

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Sep 18, 2024

Is your feature request related to a problem? Please describe

As of now, build and integration test failures are notified via GitHub issue based on CI failures.
There are few issues with this:

  1. Its completely string based. For build failure, it searches for Error building ... string and creates issues for those components. Similarly for integration tests, it follows exit codes.
  2. Even if the failure is due to CI glitch (agent nodes not coming up or windows being glicthy usually) it treats it as a component failure and creates the GH issue.
  3. Integration test failure issues are not closed automatically. This was by design as the workflow runs are run separately for each distribution, platform and architecture. An enhancement to detect no labels and close the issue was not executed. [Bug]: Auto close the created AUTOCUT integration test failure issues. #4495

Describe the solution you'd like

We are indexing all the build, test and release data in opensearch-metrics cluster.
Use this data as the source of truth to create, update and close the GH issues rather than depending on the string and CI failures.

Describe alternatives you've considered

No response

Additional context

The scope of this issue is to refactor notification only. For flaky tests detection see #4171

@gaiksaya gaiksaya added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Sep 18, 2024
@peterzhuamazon peterzhuamazon moved this from 🆕 New to 🏗 In progress in Engineering Effectiveness Board Sep 23, 2024
@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Sep 23, 2024
@gaiksaya gaiksaya moved this to Action items ✍ in OpenSearch Project Retrospective Oct 9, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Effectiveness Board Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
Status: ✅ Done
Status: Action items ✍
Development

Successfully merging a pull request may close this issue.

1 participant