Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a library to handle integration test failure issues #516

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Oct 7, 2024

Description

Issues Resolved

Related opensearch-project/opensearch-build#5038

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 85.55556% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (87cf890) to head (e047ae9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/jenkins/TestComponentIntegTestStatus.groovy 72.41% 2 Missing and 6 partials ⚠️
src/jenkins/ComponentBuildStatus.groovy 90.00% 0 Missing and 2 partials ⚠️
src/jenkins/ComponentIntegTestStatus.groovy 92.00% 0 Missing and 2 partials ⚠️
...ts/jenkins/TestCreateIntegTestMarkDownTable.groovy 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #516      +/-   ##
============================================
+ Coverage     84.46%   84.72%   +0.25%     
- Complexity       87      105      +18     
============================================
  Files           109      115       +6     
  Lines           560      648      +88     
  Branches         64       71       +7     
============================================
+ Hits            473      549      +76     
- Misses           27       29       +2     
- Partials         60       70      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…dFailureIssues library with new logic

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]>
@prudhvigodithi
Copy link
Member

NIT: Coming from gaiksaya/index-management#1 (comment), we can have hyperlinks to the URL's, this way the issue description would be more cleaner. Example for https://ci.opensearch.org/ci/dbc/integ-test/2.18.0/10364/linux/x64/tar/test-results/8750/integ-test/test-report.yml, we can have 2.18.0/10364/linux/x64/tar or your choice for if you have any better short URL in mind.

@gaiksaya
Copy link
Member Author

gaiksaya commented Oct 8, 2024

NIT: Coming from gaiksaya/index-management#1 (comment), we can have hyperlinks to the URL's, this way the issue description would be more cleaner. Example for https://ci.opensearch.org/ci/dbc/integ-test/2.18.0/10364/linux/x64/tar/test-results/8750/integ-test/test-report.yml, we can have 2.18.0/10364/linux/x64/tar or your choice for if you have any better short URL in mind.

I can take that up in next iteration if that's okay? Let's see how it goes for as is. The URLs are not that large for now. Also easy to parse to make sure we have different URLs for each distribution. Let me know what you think.

@gaiksaya gaiksaya merged commit ed71f30 into opensearch-project:main Oct 8, 2024
9 checks passed
@gaiksaya gaiksaya deleted the testNotification branch October 8, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants