-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added consolidated release notes for 1.3.8 release #3170
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3170 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 167 167
Lines 4614 4614
=======================================
Hits 4300 4300
Misses 314 314 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
## BUG FIXES | ||
|
||
### OpenSearch Anomaly Detection | ||
* Fixed dls/fls logic around numeric aggregations ([#789](https://github.com/opensearch-project/anomaly-detection/pull/789)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe uppercase DLS/FLS
since they are acronyms?
## INFRASTRUCTURE | ||
|
||
### OpenSearch Anomaly Detection | ||
* Added windows and mac CI to 1.3 ([#745](https://github.com/opensearch-project/anomaly-detection/pull/745)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows and Mac are proper nouns, so upper case first letter.
Also, the "CI" part is possibly confusing to readers of the release notes. Does this mean the support for running Anomaly Detection on Windows and Mac has been added where previously it didn't work? Or is this just an internal test/build improvement? If it is the former then I'd recommend re-wording this. If it's the latter then maybe this isn't needed for release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check on that. Thanks @andrross
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding @kaituo, Can you please respond.Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually put all commits in the release notes. Example in 2.5 release notes:
Update tool scripts to run in windows (opensearch-project/security#2371, opensearch-project/security#2379)
Fixing CI workflow to run on matrix.os (opensearch-project/job-scheduler#292)
### OpenSearch Security | ||
* Update cxf-core to 3.5.5 ([#2349](https://github.com/opensearch-project/security/pull/2349)) | ||
|
||
### OpenSearch Dashboards Security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure this naming is align with our convention? For example, https://github.com/opensearch-project/opensearch-build/blob/main/release-notes/opensearch-release-notes-2.5.0.md#opensearch-security-dashboards-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure Zelin
f85332f
to
6026c85
Compare
Signed-off-by: Divya Madala <[email protected]>
Signed-off-by: Divya Madala [email protected]
Description
Created a consolidated release notes for 1.3.8 Release
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.