Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Build Scripts for Notifications Plugin #1938

Closed
wants to merge 1 commit into from
Closed

Removing Build Scripts for Notifications Plugin #1938

wants to merge 1 commit into from

Conversation

adityaj1107
Copy link
Contributor

Description

This PR removes the build scripts for the Notifications and the Notifications Dashboard since we have a PR to add them directly to the notifications project (opensearch-project/notifications#398). We are removing them since these take precedence.

Issues Resolved

#1933

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1938 (5bf1549) into main (5e82386) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1938   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e82386...5bf1549. Read the comment docs.

gaiksaya
gaiksaya previously approved these changes Apr 7, 2022
@gaiksaya gaiksaya dismissed their stale review April 7, 2022 20:47

Waiting for other PR to get merged first

@peterzhuamazon
Copy link
Member

We will close this PR because due to BE notifications have 2 level2 subfolders within level1 subfolder, the scripts will current sit in build repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants