Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move series side config from data config panel to chart styles #1199

Conversation

ramneet-persistent
Copy link
Contributor

Description

Series 'side' config moved from data config panel to chart styles

Issues Resolved

Move series side

@ramneet-persistent ramneet-persistent requested a review from a team as a code owner October 28, 2022 17:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #1199 (3002e10) into main (f9ee36d) will decrease coverage by 0.25%.
The diff coverage is 12.00%.

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
- Coverage   47.69%   47.44%   -0.26%     
==========================================
  Files         239      240       +1     
  Lines        7217     7266      +49     
  Branches     2004     2028      +24     
==========================================
+ Hits         3442     3447       +5     
- Misses       3745     3789      +44     
  Partials       30       30              
Flag Coverage Δ
dashboards-observability 47.44% <12.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/visualizations/charts/lines/line_type.ts 77.77% <ø> (ø)
...config_panes/config_controls/config_yaxis_side.tsx 2.70% <2.70%> (ø)
...ic/components/visualizations/charts/lines/line.tsx 42.69% <27.27%> (-2.88%) ⬇️
...hboards-observability/common/constants/explorer.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
Signed-off-by: Ramneet Chopra <[email protected]>
@ramneet-persistent ramneet-persistent force-pushed the feature/move-side-to-chart-styles branch from 8bfd4ad to 3002e10 Compare November 2, 2022 10:47
@mengweieric mengweieric self-requested a review November 2, 2022 16:25
@ps48 ps48 merged commit a26f31b into opensearch-project:main Nov 2, 2022
ps48 added a commit that referenced this pull request Nov 2, 2022
derek-ho pushed a commit that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants