minor fixes

Signed-off-by: Ramneet Chopra <[email protected]>
opensearch-project · Oct 28, 2022 · 8bfd4ad · 8bfd4ad
1 parent b840507
commit 8bfd4ad
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx b/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
@@ -240,11 +240,6 @@ export const DataConfigPanelItem = ({
     }
   };
 
-  // const isPositionButtonVisible = (sectionName: string) =>
-  //   sectionName === AGGREGATIONS &&
-  //   (visualizations.vis.name === VIS_CHART_TYPES.Line ||
-  //     visualizations.vis.name === VIS_CHART_TYPES.Scatter);
-
   const getTimeStampFilteredFields = (options: IField[]) =>
     filter(options, (i: IField) => i.type !== TIMESTAMP);
 

diff --git a/dashboards-observability/public/components/visualizations/charts/lines/line.tsx b/dashboards-observability/public/components/visualizations/charts/lines/line.tsx
@@ -113,7 +113,6 @@ export const Line = ({ visualizations, layout, config }: any) => {
         fillcolor: fillColor,
       };
       const multiYaxis = { yaxis: `y${index + 1}` };
-
       const side = seriesPosition.find((seriesItem) => seriesItem.label === getPropName(field));
       multiMetrics = {
         ...multiMetrics,
@@ -200,7 +199,6 @@ export const Line = ({ visualizations, layout, config }: any) => {
         text: [],
         showlegend: false,
       };
-      const threshold = thresholds ? thresholds : [];
       const levels = availabilityConfig.level ? availabilityConfig.level : [];
 
       const mapToLine = (list: ThresholdUnitType[] | AvailabilityUnitType[], lineStyle: any) => {
@@ -239,18 +237,7 @@ export const Line = ({ visualizations, layout, config }: any) => {
       calculatedLineValues = [...calculatedLineValues, thresholdTraces];
     }
     return [mergedLayout, calculatedLineValues];
-  }, [
-    seriesPosition,
-    queriedVizData,
-    fields,
-    lastIndex,
-    layout,
-    layoutConfig,
-    xaxis,
-    mode,
-    series,
-    labelSize,
-  ]);
+  }, [queriedVizData, fields, lastIndex, layout, layoutConfig, xaxis, mode, series, labelSize]);
 
   const mergedConfigs = useMemo(
     () => ({