Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Move Date histogram to dimensions #1146

Merged

Conversation

harshada8989
Copy link
Contributor

@harshada8989 harshada8989 commented Oct 17, 2022

Signed-off-by: harshada.lingayat [email protected]

Description
Moving the date histogram section inside the dimensions panel where it will only render when any timestamp field is selected in the first dimension and once the timestamp is chosen, the option will be removed from the dimensions dropdown.

Issues Resolved
#1079
#1141
#1139

image

Check List

  • New functionality includes moving the date histogram section as a first dimension.
  • Commits are signed per the DCO using --signoff

@harshada8989 harshada8989 requested a review from a team as a code owner October 17, 2022 15:28
Signed-off-by: harshada.lingayat <[email protected]>
Signed-off-by: harshada.lingayat <[email protected]>
@harshada8989 harshada8989 force-pushed the feature/Move-DateHistogram branch from ae71080 to af0579e Compare October 17, 2022 15:29
@codecov-commenter
Copy link

Codecov Report

Merging #1146 (ae71080) into main (459289c) will increase coverage by 18.15%.
The diff coverage is n/a.

❗ Current head ae71080 differs from pull request most recent head af0579e. Consider uploading reports for the commit af0579e to get more accurate results

@@              Coverage Diff              @@
##               main    #1146       +/-   ##
=============================================
+ Coverage     53.72%   71.87%   +18.15%     
  Complexity      291      291               
=============================================
  Files           279       42      -237     
  Lines          9475     2311     -7164     
  Branches       2239      240     -1999     
=============================================
- Hits           5090     1661     -3429     
+ Misses         4215      509     -3706     
+ Partials        170      141       -29     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hboards-observability/common/constants/explorer.ts
...ponents/visualizations/charts/helpers/viz_types.ts
.../components/visualizations/charts/maps/heatmap.tsx
...nes/config_controls/config_single_color_picker.tsx
...vent_analytics/explorer/events_views/docViewer.tsx
...mponents/flyout_components/trace_detail_render.tsx
...t_analytics/explorer/hits_counter/hits_counter.tsx
...ards-observability/public/services/requests/ppl.ts
...ts/event_analytics/redux/slices/query_tab_slice.ts
...e_analytics/components/services/services_table.tsx
... and 227 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@harshada8989 harshada8989 changed the title [Feature]: Feature/move date histogram [Feature]: Move Date histogram to dimensions Oct 17, 2022
@mengweieric mengweieric merged commit 635614c into opensearch-project:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants