Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]: Move date histogram section inside dimensions #1079

Closed
harshada8989 opened this issue Oct 6, 2022 · 3 comments
Closed

[FEATURE]: Move date histogram section inside dimensions #1079

harshada8989 opened this issue Oct 6, 2022 · 3 comments
Assignees
@harshada8989
Labels
v2.4.0 'Issues and PRs related to version v2.4.0'

Comments

@harshada8989
Copy link
Contributor

Moving the date histogram section inside dimensions panel where it will only render when any timestamp field is selected in dimensions and once it is selected timestamp option will be removed from the dimensions dropdown
@harshada8989 harshada8989 added enhancement New feature or request untriaged labels Oct 6, 2022
@ruchika-narang ruchika-narang mentioned this issue Jan 3, 2023
Open
22 tasks
@mengweieric mengweieric added v2.4.0 'Issues and PRs related to version v2.4.0' and removed enhancement New feature or request untriaged labels Oct 6, 2022
@harshada8989
Copy link
Contributor Author

Hi @mengweieric @btzeng @anirudha
cc- @spattnaik @ruchika-narang
Please find the attached recording of the implemented functionality.

Move-.timestamp.mp4

@harshada8989
Copy link
Contributor Author

Hi @mengweieric @btzeng @anirudha
cc- @spattnaik @ruchika-narang
As discussed in today's sync up call

  1. The timestamp will not be a mandatory dimension. If a user does not enter any timestamp no error will be thrown.
  2. Only 1st dimension can be selected as a timestamp field i.e on the first dimension dropdown timestamp options will be available irrespective user selects the timestamp or not.
  3. Needs confirmation on an info icon which will be implemented in the dimension section informing that 1st dimension can be selected as a timestamp.

This was referenced Oct 14, 2022
Closed
Merged
@harshada8989
Copy link
Contributor Author

Feature implemented in this PR #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshada8989 harshada8989

Labels
v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harshada8989 @mengweieric