Feature : Move Date Histogram to dimensions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spattnaik
requested changes
Oct 17, 2022
Comment on lines
+143
to
+145
| const arr = [...list[name]]; | ||
| arr.splice(index, 1); | ||
| list = { ...list, [name]: arr }; |
There was a problem hiding this comment.
Take this as a future task to create an utility function to insert item at a specific position. I see this type of code so many times, those can be updated with this utility function. Make sure to de-structure the elements inside the function and not while calling it. You call the function with an array and the function is going to return you a new array using the supplied list.
There was a problem hiding this comment.
will take it in next PR and change all across the code where same logic has been implemented
...lorer/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
Outdated
Show resolved
Hide resolved
...lorer/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
Outdated
Show resolved
Hide resolved
harshada8989
force-pushed
the
feature/Move-DateHistogram
branch
from
4a11c6e to
ae71080
Compare
ruchika-narang
approved these changes
Oct 17, 2022
Signed-off-by: harshada.lingayat <[email protected]>
Signed-off-by: harshada.lingayat <[email protected]>
harshada8989
force-pushed
the
feature/Move-DateHistogram
branch
from
ae71080 to
af0579e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: harshada.lingayat [email protected]
Description
Moving the date histogram section inside dimensions panel where it will only render when any timestamp field is selected in dimensions and once it is selected timestamp option will be removed from the dimensions dropdown
Issues Resolved
opensearch-project#1079
opensearch-project#1141