[BUG]: Unable to save Heatmap Visualization and Query #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1143 +/- ##
============================================
- Coverage 53.70% 53.65% -0.05%
Complexity 291 291
============================================
Files 279 279
Lines 9490 9469 -21
Branches 2244 2231 -13
============================================
- Hits 5097 5081 -16
+ Misses 4223 4218 -5
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mengweieric
reviewed
Oct 17, 2022
dashboards-observability/public/components/event_analytics/explorer/explorer.tsx
Outdated
Show resolved
Hide resolved
ruchika-narang
force-pushed
the
bug/save-query-and-visualization
branch
from
f9f8ae4 to
a84c5dd
Compare
mengweieric
previously approved these changes
Oct 18, 2022
kavithacm
previously approved these changes
Oct 18, 2022
dashboards-observability/public/components/event_analytics/explorer/explorer.tsx
Show resolved
Hide resolved
...plorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_fields.tsx
Show resolved
Hide resolved
...plorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_fields.tsx
Outdated
Show resolved
Hide resolved
|
Please address the comments thanks |
ruchika-narang
dismissed stale reviews from kavithacm and mengweieric
via
faec5d1
ruchika-narang
force-pushed
the
bug/save-query-and-visualization
branch
from
00dc788 to
faec5d1
Compare
anirudha
previously approved these changes
Oct 19, 2022
mengweieric
requested review from
pjfitzgibbons and
anirudha
and removed request for
pjfitzgibbons
|
Please answer/resolve comments. |
I am addressing the comments and will give you the PR by your morning!! |
|
I have addressed the comments on this one, you can take a look @mengweieric . Thanks! |
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
Signed-off-by: ruchika-narang <[email protected]>
ruchika-narang
force-pushed
the
bug/save-query-and-visualization
branch
from
dc0ee25 to
bfa0988
Compare
joshuali925
approved these changes
Oct 21, 2022
mengweieric
requested review from
mengweieric
and removed request for
pjfitzgibbons
mengweieric
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix applied for save of visualizations and query.
Issues Resolved
#1100 , #1121, #1167
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.