Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauge 2way sync #1048

Merged
Merged

Conversation

abhaypersistent
Copy link
Contributor

Description

Gauge 2way sync implemented

Issues Resolved

#1012 Gauge 2Way sync

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #1048 (f2663cb) into main (bdf5291) will increase coverage by 18.26%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1048       +/-   ##
=============================================
+ Coverage     53.60%   71.87%   +18.26%     
  Complexity      291      291               
=============================================
  Files           280       42      -238     
  Lines          9309     2311     -6998     
  Branches       2135      240     -1895     
=============================================
- Hits           4990     1661     -3329     
+ Misses         4149      509     -3640     
+ Partials        170      141       -29     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/query_manager/ast/expression/AggregateTerm.ts
...anes/config_controls/config_panel_option_gauge.tsx
...ts/visualizations/charts/financial/gauge/gauge.tsx
...s_views/detail_table/table_row_icon_underscore.tsx
...ponents/common/helpers/ppl_docs/commands/search.ts
...lity/common/query_manager/ast/tree/aggragations.ts
...nfig_panes/config_controls/config_availability.tsx
...ds-observability/common/constants/custom_panels.ts
...tebooks/components/helpers/legacy_route_helpers.ts
...nents/helpers/__tests__/sampleDefaultNotebooks.tsx
... and 228 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mengweieric
mengweieric previously approved these changes Sep 29, 2022
mengweieric
mengweieric previously approved these changes Sep 30, 2022
anirudha
anirudha previously approved these changes Sep 30, 2022
@abhaypersistent abhaypersistent dismissed stale reviews from anirudha and mengweieric via b2241ba October 3, 2022 06:06
mengweieric
mengweieric previously approved these changes Oct 5, 2022
sejli
sejli previously approved these changes Oct 5, 2022
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
@mengweieric mengweieric merged commit b602ad5 into opensearch-project:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants