Gauge 2way sync #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaypersistent
force-pushed
the
gauge-2way-sync
branch
from
7918a7e to
d83cf27
Compare
| ? dataConfig[AGGREGATIONS].filter((item) => item.name !== '') | ||
| : []; | ||
| const dimensionsLength = dimensions.length; | ||
| let xaxes = dataConfig[GROUPBY] ? dataConfig[GROUPBY] : []; |
There was a problem hiding this comment.
can be written as let xaxes = dataConfig[GROUPBY] ?? [];
There was a problem hiding this comment.
ok adding the changes
| : []; | ||
| const dimensionsLength = dimensions.length; | ||
| let xaxes = dataConfig[GROUPBY] ? dataConfig[GROUPBY] : []; | ||
| const series = dataConfig[AGGREGATIONS] ? dataConfig[AGGREGATIONS] : []; |
| const xaxesLength = xaxes.length; | ||
|
|
||
| const getAggValue = (metric: any) => { | ||
| return metric.alias ? metric.alias : metric.aggregation + '' + '(' + metric.name + ')'; |
There was a problem hiding this comment.
For this used the common function created by Dipra in his PR
| }); | ||
| } | ||
| const selectedSeriesData = series.map((seriesItem: any) => { | ||
| const val = getAggValue(seriesItem); |
There was a problem hiding this comment.
Please provide a meaningful name to variable
| @@ -16,9 +16,10 @@ export const ConfigPanelOptionGauge = ({ | |||
| handleConfigChange, | |||
| }: any) => { | |||
| const { dataConfig = {} } = visualizations?.data?.userConfigs; | |||
| const dimensions = dataConfig?.valueOptions?.dimensions | |||
| ? dataConfig.valueOptions.dimensions.filter((i) => i.name !== '') | |||
| const dimensions = dataConfig?.dimensions | |||
There was a problem hiding this comment.
Change to dataConfig[GROUPBY] instead of dataConfig?.dimensions
ruchika-narang
approved these changes
Sep 28, 2022
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
Signed-off-by: Abhay Pandey <[email protected]>
abhaypersistent
force-pushed
the
gauge-2way-sync
branch
from
a25f6a9 to
cbbb10a
Compare
|
Raised external PR so, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.