-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove features and feature_list usage in Notifications #382
Conversation
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
… fix compilation errors Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
Also since the GitHub Actions for building the backend is still failing (since common-utils 2.0 snapshot is not available yet) I ran the build locally which passed:
|
What is the hold up for having the 2.0 snapshot published for common utils? |
I think from the recent plugins that were added to the 2.0 build manifest, first it was Job Scheduler (which was fixed), then it seems that Alerting was added prematurely and was failing it because it wasn't upgraded to 2.0. That was the state of things last I checked. |
Ok, maybe if Alerting is failing it we can remove Alerting from the 2.0 manifest so Common utils can get successfully published as it's required by a lot of plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, up to you if you want to wait for common utils 2.0 snapshot to get published.
I see the common-utils 2.0 snapshot is available now. The backend test workflow is failing on some flaky tests that seems to be difficult to reproduce locally. I'll merge this change in for now and look at fixing the flaky tests in a follow-up PR. |
Description
This PR is making changes to integrate the changes in opensearch-project/common-utils#136
Note: During manual testing on the frontend it became apparent that the frontend is incorrectly forming an Email channel object (the recipient is a list of Strings instead of list of EmailRecipient objects i.e
{ "recipient": "[email protected]" }
like the backend expects). We may favor the frontend format here since wrapping it in an object seems unnecessary. In either case, this will be addressed in a follow-up PR.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.