Remove feature and feature_list usage for Notifications #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
6 tasks
lezzago
reviewed
Mar 16, 2022
src/main/kotlin/org/opensearch/commons/notifications/NotificationConstants.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/commons/notifications/action/GetFeatureChannelListRequest.kt
Show resolved
Hide resolved
|
Do we want to keep the FeatureChannelList class? |
dbbaughe
reviewed
Mar 16, 2022
src/main/kotlin/org/opensearch/commons/notifications/NotificationConstants.kt
Show resolved
Hide resolved
dbbaughe
reviewed
Mar 16, 2022
src/main/kotlin/org/opensearch/commons/notifications/NotificationsPluginInterface.kt
Show resolved
Hide resolved
Signed-off-by: Mohammad Qureshi <[email protected]>
It might be renamed later and the REST handler for Notifications might be modified but we do want to keep the function since listing Channels is a little different than just listing Notifications configs (it'd collapse more complicated channels like Email) so we'd want both. |
lezzago
approved these changes
Mar 17, 2022
dbbaughe
approved these changes
Mar 17, 2022
zelinh
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Remove feature_list from NotificationConfig Signed-off-by: Mohammad Qureshi <[email protected]> * Remove feature from FeatueChannelsListRequest Signed-off-by: Mohammad Qureshi <[email protected]> * Remove 'feature' from EventSource Signed-off-by: Mohammad Qureshi <[email protected]> * Remove feature from LegacyPublishNotification Signed-off-by: Mohammad Qureshi <[email protected]> * Updated descriptions related to publishLegacyNotification Signed-off-by: Mohammad Qureshi <[email protected]> Signed-off-by: Zelin Hao <[email protected]>
wuychn
pushed a commit
to ochprince/common-utils
that referenced
this pull request
Mar 16, 2023
…roject#136) * Remove feature_list from NotificationConfig Signed-off-by: Mohammad Qureshi <[email protected]> * Remove feature from FeatueChannelsListRequest Signed-off-by: Mohammad Qureshi <[email protected]> * Remove 'feature' from EventSource Signed-off-by: Mohammad Qureshi <[email protected]> * Remove feature from LegacyPublishNotification Signed-off-by: Mohammad Qureshi <[email protected]> * Updated descriptions related to publishLegacyNotification Signed-off-by: Mohammad Qureshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There will also be a complementary PR made in the Notifications project to integrate these changes.
There are still some indirect references to features like the enabled features returned in the GetPluginFeatures API which will be addressed in a follow-up PR.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.