-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored HybridQueryPhaseSearcherTests to remove knn specific classes #977
Refactored HybridQueryPhaseSearcherTests to remove knn specific classes #977
Conversation
Signed-off-by: Owais <[email protected]>
Code looks good to me, thanks for contribution @owaiskazi19 I do see other tests where we do have dependency on the same knn classes: https://github.com/opensearch-project/neural-search/blob/main/src/test/java/org/opensearch/neuralsearch/query/HybridQueryTests.java and https://github.com/opensearch-project/neural-search/blob/main/src/test/java/org/opensearch/neuralsearch/query/HybridQueryBuilderTests.java. Did you look into those tests as well, can we do similar refactoring? |
Signed-off-by: Owais <[email protected]>
Handled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you
71017e6
into
opensearch-project:main
@owaiskazi19 could you please create a tracking issue for this if it doesn't exist? Thanks |
…es (#977) * Refactored HybridQueryPhaseSearcherTests to remove knn specific classes Signed-off-by: Owais <[email protected]> * Refactored HybridQueryTests Signed-off-by: Owais <[email protected]> --------- Signed-off-by: Owais <[email protected]> (cherry picked from commit 71017e6)
|
…es (#977) (#978) * Refactored HybridQueryPhaseSearcherTests to remove knn specific classes Signed-off-by: Owais <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
…es (#977) * Refactored HybridQueryPhaseSearcherTests to remove knn specific classes Signed-off-by: Owais <[email protected]> * Refactored HybridQueryTests Signed-off-by: Owais <[email protected]> --------- Signed-off-by: Owais <[email protected]>
Description
Refactored HybridQueryPhaseSearcherTests to remove knn specific classes
Related Issues
Resolves ##859
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.