-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Refactor HybridQuery*Tests to decouple types from K-NN library #859
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
Refactoring
Improve the design, structure, and implementation while preserving its functionality
Comments
chishui
changed the title
[FEATURE] Refactor HybridQueryPhaseSearcherTests to decouple types from K-NN library
[FEATURE] Refactor HybridQueryPhaseSearcherTests/HybridQueryTests to decouple types from K-NN library
Aug 6, 2024
chishui
changed the title
[FEATURE] Refactor HybridQueryPhaseSearcherTests/HybridQueryTests to decouple types from K-NN library
[FEATURE] Refactor HybridQuery*Tests to decouple types from K-NN library
Aug 6, 2024
We should be able to refactor HybridQueryPhaseSearcherTests and get rid of KNN specific classes, in those test cases knn query isn't required and can be replaced by other core query. |
martin-gaievski
added
Refactoring
Improve the design, structure, and implementation while preserving its functionality
good first issue
Good for newcomers
help wanted
Extra attention is needed
and removed
untriaged
enhancement
labels
Aug 7, 2024
neural-search build failed due to another k-NN update.
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
Refactoring
Improve the design, structure, and implementation while preserving its functionality
Is your feature request related to a problem?
HybridQueryPhaseSearcherTests has direct references to types in K-NN library, and it has broken the build several times recently as k-NN repo keeps refactoring their code. While a feature request was made to k-NN repo asking guarantee for backward compatibility, but there's no mechanism set up yet.
Broken test:
What solution would you like?
Can we refactor HybridQueryPhaseSearcherTests to make it not directly refer to those k-NN types?
What alternatives have you considered?
k-NN repo to have a mechanism to ensure backward compatibility.
Do you have any additional context?
NA
The text was updated successfully, but these errors were encountered: