[Backport 2.x] Backport 515 to 2.x #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#515) * Reformatting test package Signed-off-by: Varun Jain <[email protected]> * Initial commit of BWC Test Signed-off-by: Varun Jain <[email protected]> * Text Search Signed-off-by: Varun Jain <[email protected]> * Fixing bug Signed-off-by: Varun Jain <[email protected]> * Text Search bug fix Signed-off-by: Varun Jain <[email protected]> * Adding windows platform in bwc Signed-off-by: Varun Jain <[email protected]> * Adding windows platform in bwc Signed-off-by: Varun Jain <[email protected]> * Rolling Upgrade tests Signed-off-by: Varun Jain <[email protected]> * Bux Fix in rolling upgrade Signed-off-by: Varun Jain <[email protected]> * Bug Fix Rolling Upgrade Signed-off-by: Varun Jain <[email protected]> * Fixing Flaky tests Signed-off-by: Varun Jain <[email protected]> * Updating BWC version to latest Signed-off-by: Varun Jain <[email protected]> * Fixing bwc test Signed-off-by: Varun Jain <[email protected]> * Semantic Search Signed-off-by: Varun Jain <[email protected]> * Bug Fix Signed-off-by: Varun Jain <[email protected]> * Debugging Signed-off-by: Varun Jain <[email protected]> * Bug Fix Signed-off-by: Varun Jain <[email protected]> * Increase memory in nodes Signed-off-by: Varun Jain <[email protected]> * Removing extra logging Signed-off-by: Varun Jain <[email protected]> * Cleaning up Signed-off-by: Varun Jain <[email protected]> * Updating Pipeline Configuration Signed-off-by: Varun Jain <[email protected]> * Remove KNN delete models Signed-off-by: Varun Jain <[email protected]> * Remove unecessary KNN code Signed-off-by: Varun Jain <[email protected]> * Addressing comments of naveen Signed-off-by: Varun Jain <[email protected]> * Addressing comments of naveen Signed-off-by: Varun Jain <[email protected]> * Addressing comments of Naveen Signed-off-by: Varun Jain <[email protected]> * Addressing martin comments Signed-off-by: Varun Jain <[email protected]> * Addressing comments of martin Signed-off-by: Varun Jain <[email protected]> * Apply formatting.xml in all lines Signed-off-by: Varun Jain <[email protected]> * Removing extra spacess from formatting.gradle Signed-off-by: Varun Jain <[email protected]> * Addressing martin comment Signed-off-by: Varun Jain <[email protected]> * Addressing Jack comments Signed-off-by: Varun Jain <[email protected]> * Addressing Jack comments Signed-off-by: Varun Jain <[email protected]> * Addressing Jack's comments Signed-off-by: Varun Jain <[email protected]> * Fixing Test cases Signed-off-by: Varun Jain <[email protected]> * Addressing comments of Navneet Signed-off-by: Varun Jain <[email protected]> * Addressing comments of Navneet Signed-off-by: Varun Jain <[email protected]> * Addressing comments of Navneet Signed-off-by: Varun Jain <[email protected]> * Addressing comments of Navneet Signed-off-by: Varun Jain <[email protected]> * Removing extra parameter from createPipelineProcessor Signed-off-by: Varun Jain <[email protected]> * Fixing bug Signed-off-by: Varun Jain <[email protected]> * Increasing number of shards Signed-off-by: Varun Jain <[email protected]> * Bug fix of load model id Signed-off-by: Varun Jain <[email protected]> * Changing names of tests to TextEmbeddingPRocessor Signed-off-by: Varun Jain <[email protected]> * Updating indexes and replicas Signed-off-by: Varun Jain <[email protected]> --------- Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #528 +/- ##
=========================================
Coverage 85.18% 85.18%
Complexity 541 541
=========================================
Files 40 40
Lines 1580 1580
Branches 248 248
=========================================
Hits 1346 1346
Misses 117 117
Partials 117 117 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
|
We are keeping a track on why BWC rolling upgrade tests are failing for BWC version <=2.10. |
add this in the description |
navneet1v
approved these changes
Jan 3, 2024
martin-gaievski
approved these changes
Jan 3, 2024
Signed-off-by: Varun Jain <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport 515 manually to 2.x
We are keeping a track on why BWC rolling upgrade tests are failing for BWC version <=2.10.
#529
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.