Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SpotlessApply task in the project #530

Closed
3 tasks done
vibrantvarun opened this issue Jan 3, 2024 · 2 comments
Closed
3 tasks done

Add SpotlessApply task in the project #530

vibrantvarun opened this issue Jan 3, 2024 · 2 comments
Assignees
@vibrantvarun
Labels
enhancement untriaged

Comments

@vibrantvarun
Copy link
Member

vibrantvarun commented Jan 3, 2024 •
edited
Loading

Is your feature request related to a problem?

Add a gradlew spotlessApply task in the project. This will ensure a clean code by remove extra spaces and lines from all the files.

What solution would you like?

  • Create a formattingConfig.xml and add the eclipse rules
  • Write a gradle task to trigger the formatting rules and also clean the code.
  • Ensure to include all the files by providing there file extension
@vibrantvarun vibrantvarun self-assigned this Jan 3, 2024
@vibrantvarun vibrantvarun moved this from Backlog to 2.12.0 in Vector Search RoadMap Jan 3, 2024
@vibrantvarun vibrantvarun mentioned this issue Jan 3, 2024
Merged
11 tasks
@vibrantvarun
Copy link
Member Author

vibrantvarun commented Jan 3, 2024 •
edited
Loading

Code is merged.
Please run ./gradlew spotlessApply to test

@github-project-automation github-project-automation bot moved this from 2.12.0 to ✅ Done in Vector Search RoadMap Jan 3, 2024
@vibrantvarun
Copy link
Member Author

And backport PR is also merged #528

@vibrantvarun vibrantvarun moved this from ✅ Done to 2.12.0 in Vector Search RoadMap Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibrantvarun vibrantvarun

Labels
enhancement untriaged
Projects
Vector Search RoadMap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vibrantvarun