Add a setting to enable/disable local upload while registering model #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavana Goud Ramaram <[email protected]>
jngz-es
reviewed
Apr 29, 2023
Comment on lines
+8
to
+9
| import static org.opensearch.commons.ConfigConstants.*; | ||
| import static org.opensearch.ml.common.MLTask.*; |
There was a problem hiding this comment.
We should avoid import *.
There was a problem hiding this comment.
+1, but this only affects tests here so should be fine to get rid of it in the next PR.
Zhangxunmt
approved these changes
Apr 29, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #873 +/- ##
============================================
- Coverage 84.12% 84.07% -0.06%
+ Complexity 1753 1751 -2
============================================
Files 139 139
Lines 6729 6745 +16
Branches 670 672 +2
============================================
+ Hits 5661 5671 +10
- Misses 771 776 +5
- Partials 297 298 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
approved these changes
Apr 29, 2023
jngz-es
approved these changes
May 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2023
…873) Signed-off-by: Bhavana Goud Ramaram <[email protected]> (cherry picked from commit 368c362)
5 tasks
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Aug 24, 2023
…pensearch-project#873) Signed-off-by: Bhavana Goud Ramaram <[email protected]>
Merged
5 tasks
zane-neo
added a commit
that referenced
this pull request
Aug 24, 2023
…873) (#1236) Signed-off-by: Bhavana Goud Ramaram <[email protected]> Co-authored-by: Bhavana Ramaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a setting to enable/disable local upload while registering model
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.