Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to main]Add a setting to enable/disable local upload while registering model … #1236

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

zane-neo
Copy link
Collaborator

…(#873)

Description

Backport #873 to main

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1236 (758b2ae) into main (f18b850) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1236      +/-   ##
============================================
+ Coverage     84.10%   84.14%   +0.03%     
- Complexity     1757     1759       +2     
============================================
  Files           139      139              
  Lines          6727     6743      +16     
  Branches        670      672       +2     
============================================
+ Hits           5658     5674      +16     
  Misses          771      771              
  Partials        298      298              
Flag Coverage Δ
ml-commons 84.14% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.86% <100.00%> (ø)
...nsearch/ml/rest/RestMLRegisterModelMetaAction.java 100.00% <100.00%> (ø)
...ensearch/ml/rest/RestMLUploadModelChunkAction.java 100.00% <100.00%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)

@zane-neo zane-neo merged commit 7e153af into opensearch-project:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants