Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #684 +/- ##
=========================================
Coverage 83.46% 83.46%
Complexity 996 996
=========================================
Files 93 93
Lines 3660 3660
Branches 342 342
=========================================
Hits 3055 3055
Misses 460 460
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
DCO check failed, please signoff your commit @ryanbogan |
* disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]>
…now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
force-pushed
the
revert_jackson
branch
from
c7bcbc9 to
f27418d
Compare
ylwu-amzn
approved these changes
Jan 10, 2023
b4sjoo
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…now coming from core (#652)" (#684) * disable prebuilt model (#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> (cherry picked from commit d169568)
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
…now coming from core (#652)" (#684) (#774) * disable prebuilt model (#682) * disable prebuilt model * add volatile for trusted url regex * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 26435de.
Description
Jackson is no longer in core, so reverting changes made for #634
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.