-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jackson-databind and jackson-annotations dependencies now coming from core #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng from core Signed-off-by: Sicheng Song <[email protected]>
ylwu-amzn
approved these changes
Dec 29, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #652 +/- ##
============================================
- Coverage 84.91% 84.18% -0.74%
+ Complexity 986 972 -14
============================================
Files 92 92
Lines 3540 3540
Branches 326 326
============================================
- Hits 3006 2980 -26
- Misses 399 424 +25
- Partials 135 136 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jngz-es
approved these changes
Dec 29, 2022
ryanbogan
added a commit
to ryanbogan/ml-commons
that referenced
this pull request
Jan 10, 2023
…now coming from core (opensearch-project#652)" This reverts commit 26435de.
ryanbogan
added a commit
to ryanbogan/ml-commons
that referenced
this pull request
Jan 10, 2023
…now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
added a commit
to ryanbogan/ml-commons
that referenced
this pull request
Jan 10, 2023
…now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]>
b4sjoo
pushed a commit
that referenced
this pull request
Jan 10, 2023
…now coming from core (#652)" (#684) * disable prebuilt model (#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
…now coming from core (#652)" (#684) * disable prebuilt model (#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> (cherry picked from commit d169568)
5 tasks
ylwu-amzn
pushed a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
pushed a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
…ng from core (opensearch-project#652) Signed-off-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
pushed a commit
that referenced
this pull request
Mar 2, 2023
…ng from core (#652) Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
…now coming from core (opensearch-project#652)" (opensearch-project#684) * disable prebuilt model (opensearch-project#682) * disable prebuilt model Signed-off-by: Yaliang Wu <[email protected]> * add volatile for trusted url regex Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (opensearch-project#652)" This reverts commit 26435de. Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
…now coming from core (#652)" (#684) (#774) * disable prebuilt model (#682) * disable prebuilt model * add volatile for trusted url regex * Revert "Remove jackson-databind and jackson-annotations dependencies now coming from core (#652)" This reverts commit 26435de. Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Ryan Bogan <[email protected]> Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sicheng Song [email protected]
Description
jackson-databind and jackson-annotations were added as api dependencies in server of opensearch core. The security plugin now gets these dependencies transitively and does not need direct dependencies on the jars.
PR in core where the dependencies are added: opensearch-project/OpenSearch#5366
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Maintenance
Issues Resolved
This PR will resolve #634
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.