Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] add more pooling method and refactor #679

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d7f3c86 from #672

* add more pooling method and refactor

Signed-off-by: Yaliang Wu <[email protected]>

* rename poolingMethod to poolingMode

Signed-off-by: Yaliang Wu <[email protected]>

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit d7f3c86)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 9, 2023 22:11
@codecov-commenter
Copy link

Codecov Report

Merging #679 (72cc2b0) into 2.5 (2fca056) will decrease coverage by 0.81%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.5     #679      +/-   ##
============================================
- Coverage     84.18%   83.36%   -0.82%     
+ Complexity     1010      994      -16     
============================================
  Files            93       93              
  Lines          3660     3660              
  Branches        342      342              
============================================
- Hits           3081     3051      -30     
- Misses          435      463      +28     
- Partials        144      146       +2     
Flag Coverage Δ
ml-commons 83.36% <ø> (-0.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ml/model/MLModelCache.java 86.36% <ø> (ø)
.../cluster/MLCommonsClusterManagerEventListener.java 65.62% <0.00%> (-12.50%) ⬇️
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 89.39% <0.00%> (-9.10%) ⬇️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 59.39% <0.00%> (-6.60%) ⬇️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 87.50% <0.00%> (-6.25%) ⬇️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 85.71% <0.00%> (-4.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit 7e73e1e into 2.5 Jan 9, 2023
@github-actions github-actions bot deleted the backport/backport-672-to-2.5 branch January 9, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants