add more pooling method and refactor #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
rbhavna
previously approved these changes
Jan 9, 2023
jngz-es
reviewed
Jan 9, 2023
Comment on lines
+214
to
+218
| if (!"mean".equals(poolingMode) | ||
| && !"max".equals(poolingMode) | ||
| && !"cls".equals(poolingMode) | ||
| && !"mean_sqrt_len".equals(poolingMode) | ||
| && !"weightedmean".equals(poolingMode)) { |
There was a problem hiding this comment.
How about using !EnumSet.allOf(PoolingMethod.class).contains(poolingMode);?
There was a problem hiding this comment.
This is to keep consistent with DJL code. When DJL team release this translator in future, we will delete this class and use DJL text embedding translator class which doesn't have PoolingMethod enum.
jngz-es
previously approved these changes
Jan 9, 2023
Signed-off-by: Yaliang Wu <[email protected]>
jngz-es
approved these changes
Jan 9, 2023
rbhavna
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #672 +/- ##
============================================
- Coverage 83.46% 83.22% -0.25%
+ Complexity 996 992 -4
============================================
Files 93 93
Lines 3660 3660
Branches 342 342
============================================
- Hits 3055 3046 -9
- Misses 460 467 +7
- Partials 145 147 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
* add more pooling method and refactor Signed-off-by: Yaliang Wu <[email protected]> * rename poolingMethod to poolingMode Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit d7f3c86)
ylwu-amzn
added a commit
that referenced
this pull request
Jan 9, 2023
* add more pooling method and refactor Signed-off-by: Yaliang Wu <[email protected]> * rename poolingMethod to poolingMode Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit d7f3c86) Co-authored-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Feb 17, 2023
* add more pooling method and refactor Signed-off-by: Yaliang Wu <[email protected]> * rename poolingMethod to poolingMode Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 2, 2023
* add more pooling method and refactor Signed-off-by: Yaliang Wu <[email protected]> * rename poolingMethod to poolingMode Signed-off-by: Yaliang Wu <[email protected]> Signed-off-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Mar 2, 2023
* add more pooling method and refactor * rename poolingMethod to poolingMode Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.