-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a version filter to enable bwc in 2.12 #1944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee and
HenryL27
as code owners
January 29, 2024 07:37
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:37 — with
GitHub Actions
Error
b4sjoo
changed the title
Description This will fix the breaking change introduced by 2.11 Issues Resolved This will partly resolved #1838
Add a version filter to enable bwc in 2.12
Jan 29, 2024
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:42 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:42 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:42 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:43 — with
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:43 — with
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 07:43 — with
GitHub Actions
Error
ylwu-amzn
reviewed
Jan 29, 2024
@@ -530,7 +530,7 @@ private void indexRemoteModel( | |||
.build(); | |||
|
|||
IndexRequest indexModelMetaRequest = new IndexRequest(ML_MODEL_INDEX); | |||
if (registerModelInput.getIsHidden()) { | |||
if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if any other places using registerModelInput.getIsHidden()
and add null checking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found another one, added.
|
ylwu-amzn
reviewed
Jan 29, 2024
common/src/main/java/org/opensearch/ml/common/dataset/TextDocsInputDataSet.java
Outdated
Show resolved
Hide resolved
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 29, 2024 21:23 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 29, 2024 21:23 — with
GitHub Actions
Failure
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 29, 2024 21:23 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 29, 2024 21:23 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 29, 2024 21:23 — with
GitHub Actions
Inactive
Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Failure
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 00:46 — with
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Jan 31, 2024
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 01:14 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 01:14 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 01:14 — with
GitHub Actions
Inactive
jngz-es
approved these changes
Jan 31, 2024
mingshl
approved these changes
Jan 31, 2024
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
January 31, 2024 18:06 — with
GitHub Actions
Inactive
Zhangxunmt
approved these changes
Jan 31, 2024
b4sjoo
added a commit
to b4sjoo/ml-commons
that referenced
this pull request
Feb 3, 2024
Signed-off-by: Sicheng Song <[email protected]>
5 tasks
b4sjoo
added a commit
that referenced
this pull request
Feb 3, 2024
Signed-off-by: Sicheng Song <[email protected]>
austintlee
pushed a commit
to austintlee/ml-commons
that referenced
this pull request
Mar 19, 2024
…pensearch-project#2002) Signed-off-by: Sicheng Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will fix the breaking change introduced by 2.11
Issues Resolved
This will partly resolved #1838
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.