Fix all getIsHidden

Signed-off-by: Sicheng Song <[email protected]>
opensearch-project · Jan 31, 2024 · b3f8683 · b3f8683
1 parent 801ed54
commit b3f8683
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/common/src/main/java/org/opensearch/ml/common/dataset/TextDocsInputDataSet.java b/common/src/main/java/org/opensearch/ml/common/dataset/TextDocsInputDataSet.java
@@ -19,8 +19,6 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
 
 @Getter
 @FieldDefaults(makeFinal = true, level = AccessLevel.PRIVATE)

diff --git a/plugin/src/main/java/org/opensearch/ml/model/MLModelManager.java b/plugin/src/main/java/org/opensearch/ml/model/MLModelManager.java
@@ -300,7 +300,7 @@ private void uploadMLModelMeta(MLRegisterModelMetaInput mlRegisterModelMetaInput
                     .build();
                 IndexRequest indexRequest = new IndexRequest(ML_MODEL_INDEX);
 
-                if (mlRegisterModelMetaInput.getIsHidden()) {
+                if (mlRegisterModelMetaInput.getIsHidden() != null && mlRegisterModelMetaInput.getIsHidden()) {
                     indexRequest.id(modelName);
                 }
                 indexRequest.source(mlModelMeta.toXContent(XContentBuilder.builder(JSON.xContent()), EMPTY_PARAMS));
@@ -530,7 +530,7 @@ private void indexRemoteModel(
                     .build();
 
                 IndexRequest indexModelMetaRequest = new IndexRequest(ML_MODEL_INDEX);
-                if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden())  {
+                if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden()) {
                     indexModelMetaRequest.id(modelName);
                 }
                 indexModelMetaRequest.source(mlModelMeta.toXContent(XContentBuilder.builder(JSON.xContent()), EMPTY_PARAMS));
@@ -593,7 +593,7 @@ void indexRemoteModel(MLRegisterModelInput registerModelInput, MLTask mlTask, St
                     .isHidden(registerModelInput.getIsHidden())
                     .build();
                 IndexRequest indexModelMetaRequest = new IndexRequest(ML_MODEL_INDEX);
-                if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden())  {
+                if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden()) {
                     indexModelMetaRequest.id(modelName);
                 }
                 indexModelMetaRequest.source(mlModelMeta.toXContent(XContentBuilder.builder(JSON.xContent()), EMPTY_PARAMS));
@@ -740,7 +740,7 @@ private void registerModel(
                             .isHidden(registerModelInput.getIsHidden())
                             .build();
                         IndexRequest indexRequest = new IndexRequest(ML_MODEL_INDEX);
-                        if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden())  {
+                        if (registerModelInput.getIsHidden() != null && registerModelInput.getIsHidden()) {
                             indexRequest.id(modelName);
                         }
                         String chunkId = getModelChunkId(modelId, chunkNum);