Updated Testcases for RemoteModel.java #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divit Rawal <[email protected]>
divitr
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
============================================
- Coverage 78.40% 78.33% -0.07%
+ Complexity 2378 2374 -4
============================================
Files 195 195
Lines 9588 9588
Branches 964 964
============================================
- Hits 7517 7511 -6
- Misses 1633 1639 +6
Partials 438 438
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
divitr
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
divitr
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
divitr
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
|
@dhrubo-os do you know why coverage went down with an addition of a test case? |
austintlee
requested changes
Oct 25, 2023
| Connector connector = createConnector(ImmutableMap.of("Authorization", "Bearer ${credential.key}")); | ||
| when(mlModel.getConnector()).thenReturn(connector); | ||
| remoteModel.initModel(mlModel, ImmutableMap.of(), encryptor); | ||
| Assert.assertTrue(remoteModel.isModelReady()); |
There was a problem hiding this comment.
Is this going to be flaky due to timing?
| @@ -65,6 +73,15 @@ public void predict_NullConnectorExecutor() { | |||
| remoteModel.predict(mlInput); | |||
| } | |||
|
|
|||
| @Test | |||
| public void predict_ModelPredictSuccess() { | |||
There was a problem hiding this comment.
"testXYZ" and no underscore.
| when(mlModel.getConnector()).thenReturn(connector); | ||
| remoteModel.initModel(mlModel, ImmutableMap.of(), encryptor); | ||
| Assert.assertTrue(remoteModel.isModelReady()); | ||
| when(remoteConnectorExecutor.executePredict(mlInput)).thenReturn(new ModelTensorOutput(new ArrayList<>())); |
There was a problem hiding this comment.
What are you testing??
Zhangxunmt
reviewed
Nov 20, 2023
There was a problem hiding this comment.
I am going to close this PR if there's still no response to Austin's comments. @divitr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Testcases for RemoteModel.java
Issues Resolved
Resolves #1382
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.