[FEATURE]Improve test coverage for RemoteModel.java #1382
Assignees
Labels
Comments
dhrubo-os
added
enhancement
|
@dhrubo-os I would like to work on this issue. How should I get started? |
|
Sure. |
This was referenced Oct 17, 2023
|
Any update on this? |
|
@dhrubo-os Can you please assign this task to me, I will work on this. |
|
Sure, I assigned this issue to you. Thanks for looking into this. |
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Nov 7, 2024
Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
3 tasks
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Nov 8, 2024
Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Nov 11, 2024
Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Nov 12, 2024
Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Nov 14, 2024
* [FEATURE]Improve test coverage for RemoteModel.java Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> * [FEATURE]Improve test coverage for RemoteModel.java Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> * [FEATURE]Improve test coverage for RemoteModel.java Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> * [FEATURE]Improve test coverage for RemoteModel.java Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods. Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> --------- Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> (cherry picked from commit 45ff4f5)
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Dec 6, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
4 tasks
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Dec 9, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Dec 16, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
akolarkunnu
added a commit
to akolarkunnu/ml-commons
that referenced
this issue
Dec 16, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
mingshl
pushed a commit
that referenced
this issue
Dec 17, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Dec 17, 2024
This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves #1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]> (cherry picked from commit 58903ba)
tkykenmt
pushed a commit
to tkykenmt/ml-commons
that referenced
this issue
Dec 25, 2024
…-project#3260) This PR addresses the first part of this enhancement "Validate if connector payload has all the required fields. If not provided, throw the illegal argument exception". Validation of fields description, parameters, credential, and request_body are missing. That validations are added in this fix. Added new test cases correspong to these validations and fixed all failing test cases because of these new validations. Partially Resolves opensearch-project#1382 Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to improve test coverage in our repo.
This issue will target only to improve test coverage for RemoteModel.java
From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2Falgorithms%2Fremote%2FRemoteModel.java
The text was updated successfully, but these errors were encountered: