-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bwc for process function #1427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 04:39 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 04:39 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 04:39 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 04:39 — with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## 2.x #1427 +/- ##
============================================
- Coverage 78.36% 78.34% -0.02%
Complexity 2345 2345
============================================
Files 195 195
Lines 9529 9531 +2
Branches 944 944
============================================
Hits 7467 7467
- Misses 1635 1637 +2
Partials 427 427
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b4sjoo
previously approved these changes
Oct 4, 2023
dhrubo-os
reviewed
Oct 4, 2023
ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/remote/ConnectorUtils.java
Show resolved
Hide resolved
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
October 4, 2023 19:17 — with
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 19:17 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
October 4, 2023 19:17 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
October 4, 2023 19:17 — with
GitHub Actions
Inactive
b4sjoo
approved these changes
Oct 4, 2023
dhrubo-os
approved these changes
Oct 4, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Oct 4, 2023
* support bwc for process function Signed-off-by: Yaliang Wu <[email protected]> * add comment Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Oct 4, 2023
* support bwc for process function Signed-off-by: Yaliang Wu <[email protected]> * add comment Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* support bwc for process function Signed-off-by: Yaliang Wu <[email protected]> * add comment Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit efe5566)
ylwu-amzn
added a commit
that referenced
this pull request
Oct 6, 2023
* support bwc for process function Signed-off-by: Yaliang Wu <[email protected]> * add comment Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit efe5566) Co-authored-by: Yaliang Wu <[email protected]>
TrungBui59
pushed a commit
to TrungBui59/ml-commons
that referenced
this pull request
Nov 21, 2023
…h-project#1439) * support bwc for process function Signed-off-by: Yaliang Wu <[email protected]> * add comment Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit efe5566) Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: TrungBui59 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix in last PR #1407 will break BWC. This PR fixed that break.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.