Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bwc for process function #1427

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

ylwu-amzn
Copy link
Collaborator

Description

The fix in last PR #1407 will break BWC. This PR fixed that break.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 04:39 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 04:39 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 04:39 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 04:39 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1427 (792814b) into 2.x (d8c1162) will decrease coverage by 0.02%.
Report is 1 commits behind head on 2.x.
The diff coverage is 0.00%.

❗ Current head 792814b differs from pull request most recent head fee5055. Consider uploading reports for the commit fee5055 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1427      +/-   ##
============================================
- Coverage     78.36%   78.34%   -0.02%     
  Complexity     2345     2345              
============================================
  Files           195      195              
  Lines          9529     9531       +2     
  Branches        944      944              
============================================
  Hits           7467     7467              
- Misses         1635     1637       +2     
  Partials        427      427              
Flag Coverage Δ
ml-commons 78.34% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 59.78% <0.00%> (-1.33%) ⬇️

b4sjoo
b4sjoo previously approved these changes Oct 4, 2023
Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env October 4, 2023 19:17 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 19:17 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env October 4, 2023 19:17 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit efe5566 into opensearch-project:2.x Oct 4, 2023
6 of 8 checks passed
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Oct 4, 2023
* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn added a commit that referenced this pull request Oct 4, 2023
* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit efe5566)
ylwu-amzn added a commit that referenced this pull request Oct 6, 2023
* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit efe5566)

Co-authored-by: Yaliang Wu <[email protected]>
TrungBui59 pushed a commit to TrungBui59/ml-commons that referenced this pull request Nov 21, 2023
…h-project#1439)

* support bwc for process function

Signed-off-by: Yaliang Wu <[email protected]>

* add comment

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit efe5566)

Co-authored-by: Yaliang Wu <[email protected]>
Signed-off-by: TrungBui59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants