-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix text docs input unescaped error; enable deploy remote model #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
zane-neo and
Zhangxunmt
as code owners
September 29, 2023 16:04
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Error
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Failure
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 16:04 — with
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
September 29, 2023 17:04 — with
GitHub Actions
Failure
jngz-es
approved these changes
Sep 29, 2023
rbhavna
approved these changes
Sep 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 6e0d949)
jngz-es
pushed a commit
that referenced
this pull request
Sep 29, 2023
… (#1408) Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 6e0d949) Co-authored-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Oct 4, 2023
…search-project#1407) (opensearch-project#1408) Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 6e0d949) Co-authored-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Oct 4, 2023
… (#1408) Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 6e0d949) Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed two bugs
?deploy=true
, the model won't be deployed. This part disabled by https://github.com/opensearch-project/ml-commons/pull/1329/filesIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.