Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix text docs input unescaped error; enable deploy remote model #1407

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

This PR fixed two bugs

  1. When neural search plugin send text docs to remote embedding model with unescaped string, it will throw invalid json error.
  2. When user register remote model with ?deploy=true, the model won't be deployed. This part disabled by https://github.com/opensearch-project/ml-commons/pull/1329/files

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 29, 2023 16:04 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 29, 2023 16:04 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 29, 2023 17:04 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 29, 2023 17:04 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env September 29, 2023 17:04 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 6e0d949 into opensearch-project:main Sep 29, 2023
7 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 29, 2023
jngz-es pushed a commit that referenced this pull request Sep 29, 2023
… (#1408)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 6e0d949)

Co-authored-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn mentioned this pull request Oct 4, 2023
5 tasks
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Oct 4, 2023
ylwu-amzn added a commit that referenced this pull request Oct 4, 2023
… (#1408)

Signed-off-by: Yaliang Wu <[email protected]>
(cherry picked from commit 6e0d949)

Co-authored-by: Yaliang Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants