[Backport main] Fix unassigned ml system shard replicas (#1315) #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix unassigned ml system shard replicas Signed-off-by: Sicheng Song <[email protected]> * Adjust auto replica settings to keep it consistent with AOS default setting Signed-off-by: Sicheng Song <[email protected]> * Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Sicheng Song <[email protected]> * Modify exception handling Signed-off-by: Sicheng Song <[email protected]> * Modify exception messages Signed-off-by: Sicheng Song <[email protected]> * Add response check Signed-off-by: Sicheng Song <[email protected]> * Add response check and exception handling Signed-off-by: Sicheng Song <[email protected]> * Keep error message consistent Signed-off-by: Sicheng Song <[email protected]> * Keep error message consistent Signed-off-by: Sicheng Song <[email protected]> * Keep error message consistent Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Sicheng Song <[email protected]>
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
wujunshen,
ylwu-amzn,
zane-neo and
Zhangxunmt
as code owners
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
dhrubo-os
approved these changes
Sep 12, 2023
rbhavna
approved these changes
Sep 12, 2023
zane-neo
added a commit
that referenced
this pull request
Sep 26, 2023
* Add Auto Release Workflow (#1306) * Add Auto Release Workflow Signed-off-by: Sicheng Song <[email protected]> * Fix release note address Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> * Bump aws-encryption-sdk-java to fix CVE-2023-33201 (#1309) Signed-off-by: Sicheng Song <[email protected]> * Add release note for 2.10.0 release (#1312) * Add release note for 2.10.0 Signed-off-by: Sicheng Song <[email protected]> * Add CVE fix Signed-off-by: Sicheng Song <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> * fixing doc link (#1318) * fixing doc link Signed-off-by: Dhrubo Saha <[email protected]> * fixing indentation Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> * Fix unassigned ml system shard replicas (#1315) (#1324) * Fix unassigned ml system shard replicas * Adjust auto replica settings to keep it consistent with AOS default setting * Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java * Modify exception handling * Modify exception messages * Add response check * Add response check and exception handling * Keep error message consistent * Keep error message consistent * Keep error message consistent --------- Signed-off-by: Sicheng Song <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> * Adjust index replicas settings to keep consistent with AOS 2.9 (#1325) Signed-off-by: Sicheng Song <[email protected]> * Make 2.10 release notes up to date (#1345) Signed-off-by: Sicheng Song <[email protected]> * fix spelling (#1363) Signed-off-by: Kalyan <[email protected]> * Add neural search default processor for non OpenAI/Cohere scenario (#1274) * Add neural search default pre/post process function support Signed-off-by: zane-neo <[email protected]> * Fix UT failures Signed-off-by: zane-neo <[email protected]> * Address PR comment to remove nonJson response case Signed-off-by: zane-neo <[email protected]> * Fix low code coverage issue Signed-off-by: zane-neo <[email protected]> * fix format issue Signed-off-by: zane-neo <[email protected]> * Try to fix classNotFound issue in IT Signed-off-by: zane-neo <[email protected]> * revert Try to fix classNotFound issue in IT Signed-off-by: zane-neo <[email protected]> * Change gson dependency to compileOnly Signed-off-by: zane-neo <[email protected]> * Change default pre/post process function name Signed-off-by: zane-neo <[email protected]> * Address code review comments Signed-off-by: zane-neo <[email protected]> * Make preprocess function to default Signed-off-by: zane-neo <[email protected]> * Remove GsonUtil since there already a single instance in StringUtils Signed-off-by: zane-neo <[email protected]> * Fix UT failures Signed-off-by: zane-neo <[email protected]> * Address comments Signed-off-by: zane-neo <[email protected]> * use import instead of fully qualified name Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: Sicheng Song <[email protected]> Signed-off-by: Dhrubo Saha <[email protected]> Signed-off-by: Kalyan <[email protected]> Signed-off-by: zane-neo <[email protected]> Co-authored-by: Sicheng Song <[email protected]> Co-authored-by: Dhrubo Saha <[email protected]> Co-authored-by: Yaliang Wu <[email protected]> Co-authored-by: Kalyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unassigned ml system shard replicas
Adjust auto replica settings to keep it consistent with AOS default setting
Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java
Modify exception handling
Modify exception messages
Add response check
Add response check and exception handling
Keep error message consistent
Keep error message consistent
Keep error message consistent
Description
This is a backport PR for #1315
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.