Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auto Release Workflow #1306

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Add Auto Release Workflow #1306

merged 2 commits into from
Sep 8, 2023

Conversation

b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Sep 8, 2023 •
edited
Loading

Description

Add Auto Release Workflow

Issues Resolved

This should complete opensearch-project/opensearch-plugins#201 and resolve #726

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@b4sjoo
Add Auto Release Workflow
55f0e10 
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Inactive
@b4sjoo b4sjoo had a problem deploying to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Failure
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:21 — with GitHub Actions Inactive
rbhavna
rbhavna previously approved these changes Sep 8, 2023
View reviewed changes
@b4sjoo
Fix release note address
cbfa159 
Signed-off-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo temporarily deployed to ml-commons-cicd-env September 8, 2023 20:33 — with GitHub Actions Inactive
@b4sjoo b4sjoo merged commit 8bd4158 into opensearch-project:main Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1306 (55f0e10) into main (a9687fc) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 55f0e10 differs from pull request most recent head cbfa159. Consider uploading reports for the commit cbfa159 to get more accurate results

@@             Coverage Diff              @@
##               main    #1306      +/-   ##
============================================
- Coverage     78.94%   78.92%   -0.03%     
+ Complexity     2144     2142       -2     
============================================
  Files           168      168              
  Lines          8740     8740              
  Branches        877      877              
============================================
- Hits           6900     6898       -2     
- Misses         1441     1444       +3     
+ Partials        399      398       -1
Flag Coverage Δ
ml-commons 78.92% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
@b4sjoo @github-actions
Add Auto Release Workflow (#1306)
d7c3f9d 
* Add Auto Release Workflow

Signed-off-by: Sicheng Song <[email protected]>

* Fix release note address

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 8bd4158)
This was referenced Sep 8, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
@b4sjoo @github-actions
Add Auto Release Workflow (#1306)
026f0eb 
* Add Auto Release Workflow

Signed-off-by: Sicheng Song <[email protected]>

* Fix release note address

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 8bd4158)
b4sjoo added a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @b4sjoo
Add Auto Release Workflow (#1306) (#1307)
55ac8a0 
* Add Auto Release Workflow

Signed-off-by: Sicheng Song <[email protected]>

* Fix release note address

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 8bd4158)

Co-authored-by: Sicheng Song <[email protected]>
b4sjoo added a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @b4sjoo
Add Auto Release Workflow (#1306) (#1308)
9c2fbac 
* Add Auto Release Workflow

Signed-off-by: Sicheng Song <[email protected]>

* Fix release note address

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
(cherry picked from commit 8bd4158)

Co-authored-by: Sicheng Song <[email protected]>
@b4sjoo b4sjoo deleted the main_release branch September 8, 2023 20:55
zane-neo added a commit that referenced this pull request Sep 26, 2023
@zane-neo @b4sjoo
@dhrubo-os @ylwu-amzn @rawwar
Rebase main code to feature branch (#1386)
8780d1c 
* Add Auto Release Workflow (#1306)

* Add Auto Release Workflow

Signed-off-by: Sicheng Song <[email protected]>

* Fix release note address

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>

* Bump aws-encryption-sdk-java to fix CVE-2023-33201 (#1309)

Signed-off-by: Sicheng Song <[email protected]>

* Add release note for 2.10.0 release (#1312)

* Add release note for 2.10.0

Signed-off-by: Sicheng Song <[email protected]>

* Add CVE fix

Signed-off-by: Sicheng Song <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>

* fixing doc link (#1318)

* fixing doc link

Signed-off-by: Dhrubo Saha <[email protected]>

* fixing indentation

Signed-off-by: Dhrubo Saha <[email protected]>

---------

Signed-off-by: Dhrubo Saha <[email protected]>

* Fix unassigned ml system shard replicas (#1315) (#1324)

* Fix unassigned ml system shard replicas



* Adjust auto replica settings to keep it consistent with AOS default setting



* Update plugin/src/main/java/org/opensearch/ml/indices/MLIndicesHandler.java




* Modify exception handling



* Modify exception messages



* Add response check



* Add response check and exception handling



* Keep error message consistent



* Keep error message consistent



* Keep error message consistent



---------

Signed-off-by: Sicheng Song <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>

* Adjust index replicas settings to keep consistent with AOS 2.9 (#1325)

Signed-off-by: Sicheng Song <[email protected]>

* Make 2.10 release notes up to date (#1345)

Signed-off-by: Sicheng Song <[email protected]>

* fix spelling (#1363)

Signed-off-by: Kalyan <[email protected]>

* Add neural search default processor for non OpenAI/Cohere scenario (#1274)

* Add neural search default pre/post process function support

Signed-off-by: zane-neo <[email protected]>

* Fix UT failures

Signed-off-by: zane-neo <[email protected]>

* Address PR comment to remove nonJson response case

Signed-off-by: zane-neo <[email protected]>

* Fix low code coverage issue

Signed-off-by: zane-neo <[email protected]>

* fix format issue

Signed-off-by: zane-neo <[email protected]>

* Try to fix classNotFound issue in IT

Signed-off-by: zane-neo <[email protected]>

* revert Try to fix classNotFound issue in IT

Signed-off-by: zane-neo <[email protected]>

* Change gson dependency to compileOnly

Signed-off-by: zane-neo <[email protected]>

* Change default pre/post process function name

Signed-off-by: zane-neo <[email protected]>

* Address code review comments

Signed-off-by: zane-neo <[email protected]>

* Make preprocess function to default

Signed-off-by: zane-neo <[email protected]>

* Remove GsonUtil since there already a single instance in StringUtils

Signed-off-by: zane-neo <[email protected]>

* Fix UT failures

Signed-off-by: zane-neo <[email protected]>

* Address comments

Signed-off-by: zane-neo <[email protected]>

* use import instead of fully qualified name

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: Sicheng Song <[email protected]>
Signed-off-by: Dhrubo Saha <[email protected]>
Signed-off-by: Kalyan <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
Co-authored-by: Dhrubo Saha <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: Kalyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@rbhavna rbhavna rbhavna left review comments

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@wujunshen wujunshen Awaiting requested review from wujunshen

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto github release workflow
4 participants
@b4sjoo @Zhangxunmt @dhrubo-os @rbhavna