Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 2.x] fix parameter parsing bug for create connector input #1210

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Backport #1185

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 22:47 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 22:48 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 22:48 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 16, 2023 22:48 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1210 (21281b4) into 2.x (5c2dc5d) will decrease coverage by 0.05%.
Report is 1 commits behind head on 2.x.
The diff coverage is 53.06%.

@@             Coverage Diff              @@
##                2.x    #1210      +/-   ##
============================================
- Coverage     78.84%   78.80%   -0.05%     
- Complexity     2118     2124       +6     
============================================
  Files           167      167              
  Lines          8641     8676      +35     
  Branches        870      870              
============================================
+ Hits           6813     6837      +24     
- Misses         1432     1444      +12     
+ Partials        396      395       -1     
Flag Coverage Δ
ml-commons 78.80% <53.06%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 76.47% <ø> (ø)
...a/org/opensearch/ml/model/MLModelGroupManager.java 84.48% <ø> (ø)
.../main/java/org/opensearch/ml/utils/IndexUtils.java 41.17% <0.00%> (-22.46%) ⬇️
.../opensearch/ml/engine/encryptor/EncryptorImpl.java 91.04% <66.66%> (ø)
...java/org/opensearch/ml/rest/RestMLStatsAction.java 91.66% <78.94%> (-3.24%) ⬇️
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 99.04% <100.00%> (+0.03%) ⬆️
...va/org/opensearch/ml/stats/MLClusterLevelStat.java 80.00% <100.00%> (+8.57%) ⬆️

... and 3 files with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit 3d9cf34 into opensearch-project:2.x Aug 17, 2023
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants