Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameter parsing bug for create connector input #1185

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

@ylwu-amzn ylwu-amzn commented Aug 4, 2023

Description

If user input array parameter, the MLCreateConnectorInput will fail to parse. This PR fixed that bug.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 4, 2023 06:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 4, 2023 06:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 4, 2023 06:18 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 4, 2023 06:18 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #1185 (a86abf4) into 2.9 (82bddb1) will decrease coverage by 0.19%.
Report is 2 commits behind head on 2.9.
The diff coverage is 57.89%.

@@             Coverage Diff              @@
##                2.9    #1185      +/-   ##
============================================
- Coverage     78.92%   78.74%   -0.19%     
- Complexity     2119     2120       +1     
============================================
  Files           167      167              
  Lines          8633     8676      +43     
  Branches        869      870       +1     
============================================
+ Hits           6814     6832      +18     
- Misses         1423     1448      +25     
  Partials        396      396              
Flag Coverage Δ
ml-commons 78.74% <57.89%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...va/org/opensearch/ml/engine/utils/ScriptUtils.java 76.47% <ø> (ø)
...a/org/opensearch/ml/model/MLModelGroupManager.java 84.48% <ø> (ø)
.../main/java/org/opensearch/ml/utils/IndexUtils.java 41.17% <0.00%> (-22.46%) ⬇️
.../opensearch/ml/engine/encryptor/EncryptorImpl.java 91.04% <66.66%> (ø)
...java/org/opensearch/ml/rest/RestMLStatsAction.java 91.66% <78.94%> (-3.24%) ⬇️
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 70.83% <87.50%> (+2.08%) ⬆️
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 99.04% <100.00%> (+0.03%) ⬆️
...va/org/opensearch/ml/stats/MLClusterLevelStat.java 80.00% <100.00%> (+8.57%) ⬆️

... and 2 files with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit eb1a72f into opensearch-project:2.9 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants