-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fill null parameters in connector body template #1192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
August 8, 2023 23:07 — with
GitHub Actions
Failure
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
August 8, 2023 23:07 — with
GitHub Actions
Inactive
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
August 8, 2023 23:07 — with
GitHub Actions
Error
ylwu-amzn
had a problem deploying
to
ml-commons-cicd-env
August 8, 2023 23:07 — with
GitHub Actions
Failure
b4sjoo
approved these changes
Aug 8, 2023
Zhangxunmt
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
August 8, 2023 23:22 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
August 8, 2023 23:22 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
August 8, 2023 23:22 — with
GitHub Actions
Inactive
ylwu-amzn
temporarily deployed
to
ml-commons-cicd-env
August 8, 2023 23:22 — with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## 2.9 #1192 +/- ##
============================================
+ Coverage 78.74% 78.77% +0.02%
- Complexity 2119 2122 +3
============================================
Files 167 167
Lines 8676 8678 +2
Branches 870 871 +1
============================================
+ Hits 6832 6836 +4
+ Misses 1449 1447 -2
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Aug 18, 2023
) Signed-off-by: Yaliang Wu <[email protected]>
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Aug 18, 2023
Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
) (opensearch-project#1219) Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix null pointer exception when input parameter is null.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.