Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill null parameters in connector body template #1192

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Fix null pointer exception when input parameter is null.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 8, 2023 23:07 — with GitHub Actions Failure
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 8, 2023 23:07 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn had a problem deploying to ml-commons-cicd-env August 8, 2023 23:07 — with GitHub Actions Failure
Copy link
Collaborator

@Zhangxunmt Zhangxunmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 8, 2023 23:22 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 8, 2023 23:22 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 8, 2023 23:22 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env August 8, 2023 23:22 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1192 (56c9f0a) into 2.9 (fffec84) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.9    #1192      +/-   ##
============================================
+ Coverage     78.74%   78.77%   +0.02%     
- Complexity     2119     2122       +3     
============================================
  Files           167      167              
  Lines          8676     8678       +2     
  Branches        870      871       +1     
============================================
+ Hits           6832     6836       +4     
+ Misses         1449     1447       -2     
  Partials        395      395              
Flag Coverage Δ
ml-commons 78.77% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ch/ml/engine/algorithms/remote/ConnectorUtils.java 71.62% <100.00%> (+0.78%) ⬆️

... and 1 file with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit 4ac47f6 into opensearch-project:2.9 Aug 8, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Aug 18, 2023
ylwu-amzn added a commit that referenced this pull request Aug 18, 2023
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants