fix:admin with no backend role on AOS unable to create restricted mod…

…el group (#1188) Signed-off-by: Bhavana Ramaram <[email protected]>
opensearch-project · Aug 7, 2023 · fffec84 · fffec84
1 parent eb1a72f
commit fffec84
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/plugin/src/main/java/org/opensearch/ml/model/MLModelGroupManager.java b/plugin/src/main/java/org/opensearch/ml/model/MLModelGroupManager.java
@@ -167,7 +167,7 @@ private void validateRequestForAccessControl(MLRegisterModelGroupInput input, Us
             if (modelAccessControlHelper.isAdmin(user) && Boolean.TRUE.equals(isAddAllBackendRoles)) {
                 throw new IllegalArgumentException("Admin users cannot add all backend roles to a model group.");
             }
-            if (CollectionUtils.isEmpty(user.getBackendRoles())) {
+            if (!modelAccessControlHelper.isAdmin(user) && CollectionUtils.isEmpty(user.getBackendRoles())) {
                 throw new IllegalArgumentException("You must have at least one backend role to register a restricted model group.");
             }
             if (CollectionUtils.isEmpty(input.getBackendRoles()) && !Boolean.TRUE.equals(isAddAllBackendRoles)) {