Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:admin with no backend role on AOS unable to create restricted model group #1188

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Aug 7, 2023

Description

fix:admin with no backend role on AOS unable to create restricted model group

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env August 7, 2023 19:11 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env August 7, 2023 19:11 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env August 7, 2023 19:11 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env August 7, 2023 19:11 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1188 (d351e84) into 2.9 (eb1a72f) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                2.9    #1188   +/-   ##
=========================================
  Coverage     78.78%   78.78%           
- Complexity     2121     2122    +1     
=========================================
  Files           167      167           
  Lines          8676     8676           
  Branches        870      870           
=========================================
  Hits           6835     6835           
+ Misses         1447     1444    -3     
- Partials        394      397    +3     
Flag Coverage Δ
ml-commons 78.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...a/org/opensearch/ml/model/MLModelGroupManager.java 83.62% <0.00%> (-0.87%) ⬇️

... and 3 files with indirect coverage changes

@rbhavna rbhavna merged commit fffec84 into opensearch-project:2.9 Aug 7, 2023
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Aug 18, 2023
ylwu-amzn added a commit that referenced this pull request Aug 18, 2023
…el group (#1188) (#1218)

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Bhavana Ramaram <[email protected]>
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
…el group (#1188) (#1218)

Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Bhavana Ramaram <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants