Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector transport actions and disable native memory CB #1056

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Zhangxunmt
Copy link
Collaborator

Description

add connector transport actions and disable native memory circuit breakers.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested review from ylwu-amzn and zane-neo July 9, 2023 20:18
import lombok.extern.log4j.Log4j2;

@Log4j2
public class ConnectorAccessControlHelper {
Copy link
Collaborator

@ylwu-amzn ylwu-amzn Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class already included in Zan's PR: #1055

Update: I see why you have to add this class. The connector transport action depends on this class.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing without this class. So let's merge this 1055 PR first.

@Zhangxunmt Zhangxunmt force-pushed the 2.x branch 2 times, most recently from 1f824fe to 2d4ab84 Compare July 10, 2023 04:45
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1056 (e2ea585) into 2.x (11b72bc) will decrease coverage by 2.16%.
The diff coverage is 2.17%.

@@             Coverage Diff              @@
##                2.x    #1056      +/-   ##
============================================
- Coverage     78.51%   76.36%   -2.16%     
+ Complexity     1978     1976       -2     
============================================
  Files           158      162       +4     
  Lines          8047     8275     +228     
  Branches        809      830      +21     
============================================
+ Hits           6318     6319       +1     
- Misses         1363     1589     +226     
- Partials        366      367       +1     
Flag Coverage Δ
ml-commons 76.36% <2.17%> (-2.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tion/connector/DeleteConnectorTransportAction.java 0.00% <0.00%> (ø)
.../action/connector/GetConnectorTransportAction.java 0.00% <0.00%> (ø)
...tion/connector/SearchConnectorTransportAction.java 0.00% <0.00%> (ø)
...tion/connector/TransportCreateConnectorAction.java 0.00% <0.00%> (ø)
...opensearch/ml/breaker/MLCircuitBreakerService.java 100.00% <ø> (ø)
...va/org/opensearch/ml/indices/MLIndicesHandler.java 68.91% <0.00%> (-1.92%) ⬇️
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.94% <ø> (ø)
...rg/opensearch/ml/breaker/MemoryCircuitBreaker.java 64.28% <16.66%> (-35.72%) ⬇️
...c/main/java/org/opensearch/ml/indices/MLIndex.java 93.33% <100.00%> (+0.47%) ⬆️
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Zhangxunmt Zhangxunmt merged commit 84b4382 into opensearch-project:2.x Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants