Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic connector access control classes #1055

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Jul 9, 2023

Description

Add basic connector access control classes

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zane-neo zane-neo requested review from ylwu-amzn and Zhangxunmt July 9, 2023 14:44
@ylwu-amzn
Copy link
Collaborator

Need to run ./gradlew spotlessApply to format code

@zane-neo zane-neo force-pushed the remote-inference-connector-access-control branch from 61aade1 to b9c4036 Compare July 10, 2023 00:49
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1055 (b9c4036) into 2.x (c989d61) will decrease coverage by 0.03%.
The diff coverage is 78.16%.

@@             Coverage Diff              @@
##                2.x    #1055      +/-   ##
============================================
- Coverage     78.56%   78.53%   -0.03%     
- Complexity     1944     1980      +36     
============================================
  Files           157      158       +1     
  Lines          7960     8047      +87     
  Branches        797      809      +12     
============================================
+ Hits           6254     6320      +66     
- Misses         1352     1361       +9     
- Partials        354      366      +12     
Flag Coverage Δ
ml-commons 78.53% <78.16%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...search/ml/helper/ConnectorAccessControlHelper.java 76.54% <76.54%> (ø)
.../org/opensearch/ml/settings/MLCommonsSettings.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@zane-neo zane-neo merged commit 11b72bc into opensearch-project:2.x Jul 10, 2023
zane-neo added a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
* Add basic connector access control classes

Signed-off-by: zane-neo <[email protected]>

* Add basic connector access control classes and fformat code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
zane-neo added a commit that referenced this pull request Sep 1, 2023
* Add basic connector access control classes

Signed-off-by: zane-neo <[email protected]>

* Add basic connector access control classes and fformat code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants