-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support external models in deployed model list #248
feat: support external models in deployed model list #248
Conversation
Signed-off-by: Lin Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 78.53% 80.00% +1.46%
==========================================
Files 20 25 +5
Lines 382 470 +88
Branches 75 101 +26
==========================================
+ Hits 300 376 +76
- Misses 60 67 +7
- Partials 22 27 +5 |
id?: string; | ||
name?: string; | ||
description?: string; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the params passed be
connector?: { id?: string; name: string; description?: string; };
?
Or in the case of external, the name may also be empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me check if we can modify this name to required.
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
const handleFilterItemClick = useCallback((clickItemValue: T) => { | ||
onChangeRef.current( | ||
valueRef.current.includes(clickItemValue) | ||
? valueRef.current.filter((item) => item !== clickItemValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't hold a strong opinion, but just want to discuss this with you. I kinda feel it's a bit over-optimize to assign the props to a ref, like onChangeRef
and valueRef
. I understand using ref could avoid a few re-renders. Personally, I'd do optimization when facing the actual performance problem instead of optimize the code too early.
|
||
return ( | ||
<EuiPopover | ||
id="popoverExampleMultiSelect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should give it a more appropriate name instead calling it some "example"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component was copy from the feature/model-registry
branch, forget to remove id. Will leave an id property and pass different value from outside.
|
||
for (const connectorName of internalConnectorNames) { | ||
if (!uniqueExternalConnectors[connectorName]) { | ||
uniqueExternalConnectors[connectorName] = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you leave a comment to elaborate why set it to []
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#We don't need these codes after filter refactor, forget to removed.
|
||
type SourceOptionValue = 'local' | 'external'; | ||
|
||
const sourceOptions = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to name it as SOURCE_OPTIONS
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
* feat: support external models in deployed model list Signed-off-by: Lin Wang <[email protected]> * refactor: update name to required Signed-off-by: Lin Wang <[email protected]> * fix: connector index not found Signed-off-by: Lin Wang <[email protected]> * refactor: update options filter with normal string[] value Signed-off-by: Lin Wang <[email protected]> * fix: hits not defined Signed-off-by: Lin Wang <[email protected]> * fix: update wording Signed-off-by: Lin Wang <[email protected]> * fix: connector id not exists in all connectors Signed-off-by: Lin Wang <[email protected]> * fix: show models when failed to load all external connectors Signed-off-by: Lin Wang <[email protected]> * feat: update deployed models title to models Signed-off-by: Lin Wang <[email protected]> * refactor: remove unused code in model connector filter Signed-off-by: Lin Wang <[email protected]> * feat: address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc3810b)
* feat: support external models in deployed model list Signed-off-by: Lin Wang <[email protected]> * refactor: update name to required Signed-off-by: Lin Wang <[email protected]> * fix: connector index not found Signed-off-by: Lin Wang <[email protected]> * refactor: update options filter with normal string[] value Signed-off-by: Lin Wang <[email protected]> * fix: hits not defined Signed-off-by: Lin Wang <[email protected]> * fix: update wording Signed-off-by: Lin Wang <[email protected]> * fix: connector id not exists in all connectors Signed-off-by: Lin Wang <[email protected]> * fix: show models when failed to load all external connectors Signed-off-by: Lin Wang <[email protected]> * feat: update deployed models title to models Signed-off-by: Lin Wang <[email protected]> * refactor: remove unused code in model connector filter Signed-off-by: Lin Wang <[email protected]> * feat: address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc3810b) Co-authored-by: Lin Wang <[email protected]>
* Increment version to 2.8.0.0 (#169) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * chore: update husky to 8.0.3 to avoid use execa (#160) (#189) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 6a3faee) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.8.0 (#190) (#191) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit f2b701b) Co-authored-by: Lin Wang <[email protected]> * feat: remove experiment warning banner (#194) (#195) * feat: remove experiment warning banner Signed-off-by: Lin Wang <[email protected]> * doc: update release notes for remove experiment banner Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 0ef4753) Co-authored-by: Lin Wang <[email protected]> * feat: enable ml-commons-dashboards plugin by default (#200) (#201) * feat: enable ml-commons-dashboards plugin by default Signed-off-by: Lin Wang <[email protected]> * feat: update release notes for enable plugin by default Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit a1cb7de) Co-authored-by: Lin Wang <[email protected]> * Revert remove experiment banner and enable by default (#203) (#204) * Revert "feat: enable ml-commons-dashboards plugin by default (#200)" This reverts commit a1cb7de. Signed-off-by: Lin Wang <[email protected]> * Revert "feat: remove experiment warning banner (#194)" This reverts commit 0ef4753. Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 31df7d4) Co-authored-by: Lin Wang <[email protected]> * remove background for dark mode to fix #206 (#209) (#212) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2bc3f38) Co-authored-by: Lin Wang <[email protected]> * Fix ml document link address (#210) (#213) * update to correct machine learning document address to fix #208 Signed-off-by: Lin Wang <[email protected]> * fix: update link in deployment table empty screen Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 7a33d01) Co-authored-by: Lin Wang <[email protected]> * feat: open external link in blank page (#211) (#214) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit e2825c4) Co-authored-by: Lin Wang <[email protected]> * Increment version to 2.9.0.0 (#222) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: exclude remote model for admin UI (#225) (#228) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit ba01d34) Co-authored-by: Lin Wang <[email protected]> * Revert "Revert remove experiment banner and enable by default (#203)" (#229) (#231) * Revert "Revert remove experiment banner and enable by default (#203)" This reverts commit 31df7d4. Signed-off-by: Lin Wang <[email protected]> * doc: remove release update for 2.8.0 Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 2caf020) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.9.0 (#232) (#233) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 02e80a9) Co-authored-by: Lin Wang <[email protected]> * Add source field to distinguish local and external model (#239) (#240) * Revert "feat: exclude remote model for admin UI (#225)" This reverts commit ba01d34. Signed-off-by: Lin Wang <[email protected]> * feat: add source field to distinguish local and external model Signed-off-by: Lin Wang <[email protected]> * feat: add miss display words Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 63c7a5a) Co-authored-by: Lin Wang <[email protected]> * Fix no model show up when search a model (#238) (#242) * fix: reset to page 1 after name or state search Signed-off-by: Lin Wang <[email protected]> * refactor: remove unnecessary act call Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 24aa9df) Co-authored-by: Lin Wang <[email protected]> * Feat mitigate to oui style variables (#227) (#246) * feat: remove customized font size and font weight Signed-off-by: Lin Wang <[email protected]> * feat: update color to $ouiLinkColor Signed-off-by: Lin Wang <[email protected]> * feat: remove white background for refresh interval Signed-off-by: Lin Wang <[email protected]> * remove ace theme Signed-off-by: Lin Wang <[email protected]> * refactor: update <b> to <strong> Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit 3aa8eaf) Co-authored-by: Lin Wang <[email protected]> * feat: support external models in deployed model list (#248) (#251) * feat: support external models in deployed model list Signed-off-by: Lin Wang <[email protected]> * refactor: update name to required Signed-off-by: Lin Wang <[email protected]> * fix: connector index not found Signed-off-by: Lin Wang <[email protected]> * refactor: update options filter with normal string[] value Signed-off-by: Lin Wang <[email protected]> * fix: hits not defined Signed-off-by: Lin Wang <[email protected]> * fix: update wording Signed-off-by: Lin Wang <[email protected]> * fix: connector id not exists in all connectors Signed-off-by: Lin Wang <[email protected]> * fix: show models when failed to load all external connectors Signed-off-by: Lin Wang <[email protected]> * feat: update deployed models title to models Signed-off-by: Lin Wang <[email protected]> * refactor: remove unused code in model connector filter Signed-off-by: Lin Wang <[email protected]> * feat: address PR comments Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc3810b) Co-authored-by: Lin Wang <[email protected]> * update preview panel for external models (#252) (#253) * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> * feat: update preview panel for external models Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit 9bbd25f) Co-authored-by: raintygao <[email protected]> * Increment version to 2.10.0.0 (#237) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * feat: update ui component and use fallback (#254) (#256) Signed-off-by: tygao <[email protected]> * feat: replace dash with em dash (#255) (#257) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit b817d98) Co-authored-by: Lin Wang <[email protected]> * doc: add release notes for 2.10 (#258) (#259) * doc: add release notes for 2.10 Signed-off-by: tygao <[email protected]> * doc: append prs Signed-off-by: tygao <[email protected]> * doc: separate prs Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> (cherry picked from commit db0003d) Co-authored-by: tygao <[email protected]> * Increment version to 2.11.0.0 (#265) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> * doc: add release notes for 2.11.0.0 (#276) (#277) Signed-off-by: Lin Wang <[email protected]> (cherry picked from commit cc2d58e) Co-authored-by: Lin Wang <[email protected]> * Onboard jenkins build docker image to ml-commons-dashboards github ci checks 2.x (#281) Signed-off-by: Peter Zhu <[email protected]> * Increment version to 2.12.0.0 (#279) Signed-off-by: opensearch-ci-bot <[email protected]> Co-authored-by: opensearch-ci-bot <[email protected]> --------- Signed-off-by: opensearch-ci-bot <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <[email protected]> Co-authored-by: raintygao <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Description
Support external models in the deployed model list
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.