Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no model show up when search a model #238

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix no model show up when search a model #238

merged 2 commits into from
Aug 2, 2023

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Jul 31, 2023

Description

Fix #236 , reset to first page after name or state change.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #238 (06becc2) into main (63c7a5a) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   78.38%   78.64%   +0.26%     
==========================================
  Files          20       20              
  Lines         384      384              
  Branches       76       76              
==========================================
+ Hits          301      302       +1     
  Misses         60       60              
+ Partials       23       22       -1

see 1 file with indirect coverage changes

@wanglam wanglam marked this pull request as ready for review July 31, 2023 06:24
@wanglam wanglam requested review from ruanyl and raintygao as code owners July 31, 2023 06:24
ruanyl
ruanyl approved these changes Jul 31, 2023
View reviewed changes
public/components/monitoring/tests/use_monitoring.test.ts Outdated
expect(result.current.pagination?.currentPage).toBe(2);
});

act(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it doesn't need act()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed. Since we've already call waitFor below.

@wanglam wanglam force-pushed the fix/filter-with-pagination-no-results branch from 4d13450 to 06becc2 Compare August 2, 2023 09:43
@wanglam wanglam merged commit 24aa9df into opensearch-project:main Aug 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
@wanglam @github-actions
Fix no model show up when search a model (#238)
b31080b 
* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 2, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
@wanglam @github-actions
Fix no model show up when search a model (#238)
6c2c775 
* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 2, 2023
Merged
wanglam added a commit that referenced this pull request Aug 2, 2023
@opensearch-trigger-bot @wanglam
Fix no model show up when search a model (#238) (#242)
7ed315e 
* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)

Co-authored-by: Lin Wang <[email protected]>
wanglam added a commit that referenced this pull request Aug 2, 2023
@opensearch-trigger-bot @wanglam
Fix no model show up when search a model (#238) (#243)
ecb64e8 
* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)

Co-authored-by: Lin Wang <[email protected]>
@wanglam wanglam mentioned this pull request Sep 4, 2023
Merged
wanglam added a commit that referenced this pull request Nov 16, 2023
@wanglam @opensearch-trigger-bot
@opensearch-ci-bot @raintygao @peterzhuamazon
Merge 2.x to model registry (#289)
54f8603 
* Increment version to 2.8.0.0 (#169)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* chore: update husky to 8.0.3 to avoid use execa (#160) (#189)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 6a3faee)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.8.0 (#190) (#191)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit f2b701b)

Co-authored-by: Lin Wang <[email protected]>

* feat: remove experiment warning banner (#194) (#195)

* feat: remove experiment warning banner

Signed-off-by: Lin Wang <[email protected]>

* doc: update release notes for remove experiment banner

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 0ef4753)

Co-authored-by: Lin Wang <[email protected]>

* feat: enable ml-commons-dashboards plugin by default (#200) (#201)

* feat: enable ml-commons-dashboards plugin by default

Signed-off-by: Lin Wang <[email protected]>

* feat: update release notes for enable plugin by default

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit a1cb7de)

Co-authored-by: Lin Wang <[email protected]>

* Revert remove experiment banner and enable by default (#203) (#204)

* Revert "feat: enable ml-commons-dashboards plugin by default (#200)"

This reverts commit a1cb7de.

Signed-off-by: Lin Wang <[email protected]>

* Revert "feat: remove experiment warning banner (#194)"

This reverts commit 0ef4753.

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 31df7d4)

Co-authored-by: Lin Wang <[email protected]>

* remove background for dark mode to fix #206 (#209) (#212)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 2bc3f38)

Co-authored-by: Lin Wang <[email protected]>

* Fix ml document link address (#210) (#213)

* update to correct machine learning document address to fix #208

Signed-off-by: Lin Wang <[email protected]>

* fix: update link in deployment table empty screen

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 7a33d01)

Co-authored-by: Lin Wang <[email protected]>

* feat: open external link in blank page (#211) (#214)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit e2825c4)

Co-authored-by: Lin Wang <[email protected]>

* Increment version to 2.9.0.0 (#222)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* feat: exclude remote model for admin UI (#225) (#228)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit ba01d34)

Co-authored-by: Lin Wang <[email protected]>

* Revert "Revert remove experiment banner and enable by default (#203)" (#229) (#231)

* Revert "Revert remove experiment banner and enable by default (#203)"

This reverts commit 31df7d4.

Signed-off-by: Lin Wang <[email protected]>

* doc: remove release update for 2.8.0

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 2caf020)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.9.0 (#232) (#233)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 02e80a9)

Co-authored-by: Lin Wang <[email protected]>

* Add source field to distinguish local and external model (#239) (#240)

* Revert "feat: exclude remote model for admin UI (#225)"

This reverts commit ba01d34.

Signed-off-by: Lin Wang <[email protected]>

* feat: add source field to distinguish local and external model

Signed-off-by: Lin Wang <[email protected]>

* feat: add miss display words

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 63c7a5a)

Co-authored-by: Lin Wang <[email protected]>

* Fix no model show up when search a model (#238) (#242)

* fix: reset to page 1 after name or state search

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unnecessary act call

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 24aa9df)

Co-authored-by: Lin Wang <[email protected]>

* Feat mitigate to oui style variables (#227) (#246)

* feat: remove customized font size and font weight

Signed-off-by: Lin Wang <[email protected]>

* feat: update color to $ouiLinkColor

Signed-off-by: Lin Wang <[email protected]>

* feat: remove white background for refresh interval

Signed-off-by: Lin Wang <[email protected]>

* remove ace theme

Signed-off-by: Lin Wang <[email protected]>

* refactor: update <b> to <strong>

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 3aa8eaf)

Co-authored-by: Lin Wang <[email protected]>

* feat: support external models in deployed model list (#248) (#251)

* feat: support external models in deployed model list

Signed-off-by: Lin Wang <[email protected]>

* refactor: update name to required

Signed-off-by: Lin Wang <[email protected]>

* fix: connector index not found

Signed-off-by: Lin Wang <[email protected]>

* refactor: update options filter with normal string[] value

Signed-off-by: Lin Wang <[email protected]>

* fix: hits not defined

Signed-off-by: Lin Wang <[email protected]>

* fix: update wording

Signed-off-by: Lin Wang <[email protected]>

* fix: connector id not exists in all connectors

Signed-off-by: Lin Wang <[email protected]>

* fix: show models when failed to load all external connectors

Signed-off-by: Lin Wang <[email protected]>

* feat: update deployed models title to models

Signed-off-by: Lin Wang <[email protected]>

* refactor: remove unused code in model connector filter

Signed-off-by: Lin Wang <[email protected]>

* feat: address PR comments

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit cc3810b)

Co-authored-by: Lin Wang <[email protected]>

* update preview panel for external models (#252) (#253)

* feat: update preview panel for external models

Signed-off-by: tygao <[email protected]>

* feat: update preview panel for external models

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
(cherry picked from commit 9bbd25f)

Co-authored-by: raintygao <[email protected]>

* Increment version to 2.10.0.0 (#237)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* feat: update ui component and use fallback (#254) (#256)

Signed-off-by: tygao <[email protected]>

* feat: replace dash with em dash (#255) (#257)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit b817d98)

Co-authored-by: Lin Wang <[email protected]>

* doc: add release notes for 2.10 (#258) (#259)

* doc: add release notes for 2.10

Signed-off-by: tygao <[email protected]>

* doc: append prs

Signed-off-by: tygao <[email protected]>

* doc: separate prs

Signed-off-by: tygao <[email protected]>

---------

Signed-off-by: tygao <[email protected]>
(cherry picked from commit db0003d)

Co-authored-by: tygao <[email protected]>

* Increment version to 2.11.0.0 (#265)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

* doc: add release notes for 2.11.0.0 (#276) (#277)

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit cc2d58e)

Co-authored-by: Lin Wang <[email protected]>

* Onboard jenkins build docker image to ml-commons-dashboards github ci checks 2.x (#281)

Signed-off-by: Peter Zhu <[email protected]>

* Increment version to 2.12.0.0 (#279)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>

---------

Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: raintygao <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.9 v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Admin UI: no model show up when search a model
3 participants
@wanglam @ruanyl @raintygao