Adding test for KNNWeight #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
Infrastructure
martin-gaievski
commented
Feb 10, 2023
| @@ -165,6 +165,9 @@ dependencies { | |||
| api group: 'com.google.guava', name: 'guava', version:'30.0-jre' | |||
| api group: 'commons-lang', name: 'commons-lang', version: '2.6' | |||
| testFixturesImplementation "org.opensearch.test:framework:${opensearch_version}" | |||
| testImplementation group: 'net.bytebuddy', name: 'byte-buddy', version: '1.12.22' | |||
| testImplementation group: 'org.objenesis', name: 'objenesis', version: '3.2' | |||
| testImplementation group: 'net.bytebuddy', name: 'byte-buddy-agent', version: '1.12.22' | |||
There was a problem hiding this comment.
this is required to mock static classes/methods
There was a problem hiding this comment.
Quick feedback on this:
- Is there a possibility that we fix src so that we don't need to mock static functions.
- Are we using junit4 or junit5 here?
There was a problem hiding this comment.
Making changes in source will be problematic, there are many such classes involved in call chain.
We're using junit4, 4.13 to be precise.
martin-gaievski
commented
Feb 10, 2023
| @@ -196,6 +199,7 @@ test { | |||
| dependsOn buildJniLib | |||
| systemProperty 'tests.security.manager', 'false' | |||
| systemProperty "java.library.path", "$rootDir/jni/release" | |||
| systemProperty "jdk.attach.allowAttachSelf", true | |||
There was a problem hiding this comment.
this is required to mock static classes/methods
There was a problem hiding this comment.
Add a comment in the file itself.
martin-gaievski
force-pushed
the
add-tests-for-knn-weight
branch
5 times, most recently
from
167bf29 to
3ee085e
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
add-tests-for-knn-weight
branch
from
3ee085e to
6396272
Compare
jmazanec15
reviewed
Feb 14, 2023
src/test/java/org/opensearch/knn/index/query/KNNWeightTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
jmazanec15
reviewed
Feb 14, 2023
| try { | ||
| testQueryScore(space::scoreTranslation, SEGMENT_FILES_NMSLIB, Map.of(SPACE_TYPE, space.getValue())); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
that's the syntax required in case we're using forEach. Let me change it to something less verbose and without required catch.
Signed-off-by: Martin Gaievski <[email protected]>
jmazanec15
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
LGTM thanks for adding these @martin-gaievski! This improves our coverage greatly!
naveentatikonda
approved these changes
Feb 14, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-759-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5b06cfe8902920161f6515347b49fcb2eae3e4e7
# Push it to GitHub
git push --set-upstream origin backport/backport-759-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.xThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
* Adding test for KNNWeight Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 5b06cfe)
martin-gaievski
added a commit
that referenced
this pull request
Feb 14, 2023
* Adding test for KNNWeight Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 5b06cfe) Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Gaievski [email protected]
Description
We do not have unit tests for KNNWeight, having it would help to catch issues with size of DocIdSetBuilder, like #500 and #751. Along with test adding dependencies for doing mocks of static classes and/or methods.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.